Skip to content

Commit

Permalink
feat(engine): Fail workflow defintion getter slow
Browse files Browse the repository at this point in the history
  • Loading branch information
topher-lo committed Jan 21, 2025
1 parent a07f599 commit 49c238f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
6 changes: 5 additions & 1 deletion tracecat/dsl/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@
maximum_attempts=1,
non_retryable_error_types=non_retryable_error_types,
),
"activity:fail_slow": RetryPolicy(
maximum_attempts=6,
non_retryable_error_types=non_retryable_error_types,
),
"workflow:fail_fast": RetryPolicy(
# XXX: Do not set max attempts to 0, it will default to unlimited
maximum_attempts=1,
Expand Down Expand Up @@ -638,7 +642,7 @@ async def _get_workflow_definition(
get_workflow_definition_activity,
arg=activity_inputs,
start_to_close_timeout=self.start_to_close_timeout,
retry_policy=retry_policies["activity:fail_fast"],
retry_policy=retry_policies["activity:fail_slow"],
)

async def _validate_trigger_inputs(
Expand Down
10 changes: 5 additions & 5 deletions tracecat/workflow/management/definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ async def get_workflow_definition_activity(
defn = await service.get_definition_by_workflow_id(
input.workflow_id, version=input.version
)
if not defn:
msg = f"Workflow definition not found for {input.workflow_id!r}, version={input.version}"
logger.error(msg)
raise TracecatException(msg)
dsl = DSLInput(**defn.content)
if not defn:
msg = f"Workflow definition not found for {input.workflow_id!r}, version={input.version}"
logger.error(msg)
raise TracecatException(msg)
dsl = DSLInput(**defn.content)
return dsl

0 comments on commit 49c238f

Please sign in to comment.