Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the implementation of the salt and the CIDR tool. #51

Merged
merged 3 commits into from
May 9, 2024

Conversation

wa5i
Copy link
Collaborator

@wa5i wa5i commented Apr 19, 2024

No description provided.

@wa5i wa5i requested a review from InfoHunter April 19, 2024 10:37
@InfoHunter
Copy link
Member

What is the use case of those newly added tool moduels?

Copy link
Member

@InfoHunter InfoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, is all code being reviewed original? Otherwise we need to declare the origination of the code.

@wa5i
Copy link
Collaborator Author

wa5i commented Apr 28, 2024

What is the use case of those newly added tool moduels?

The approle module to be submitted later will use these two tools.

@wa5i
Copy link
Collaborator Author

wa5i commented Apr 28, 2024

Besides, is all code being reviewed original? Otherwise we need to declare the origination of the code.

These codes refer to the Golang implementation of Vault. In this case, do we still need to declare the source?

@InfoHunter
Copy link
Member

Where is the original Golang implementation?

@wa5i
Copy link
Collaborator Author

wa5i commented May 6, 2024

src/utils/mod.rs Outdated Show resolved Hide resolved
@InfoHunter
Copy link
Member

https://github.com/hashicorp/vault/blob/main/sdk/helper/salt/salt.go
https://github.com/hashicorp/vault/blob/main/sdk/helper/cidrutil/cidr.go

You may add something like this to the beginning of the file:

//! This module is a Rust replica of
//! https://github.com/hashicorp/vault/blob/main/sdk/helper/salt/salt.go

And:

//! This module is a Rust replica of
//! https://github.com/hashicorp/vault/blob/main/sdk/helper/cidrutil/cidr.go

@wa5i
Copy link
Collaborator Author

wa5i commented May 9, 2024

https://github.com/hashicorp/vault/blob/main/sdk/helper/salt/salt.go
https://github.com/hashicorp/vault/blob/main/sdk/helper/cidrutil/cidr.go

You may add something like this to the beginning of the file:

//! This module is a Rust replica of
//! https://github.com/hashicorp/vault/blob/main/sdk/helper/salt/salt.go

And:

//! This module is a Rust replica of
//! https://github.com/hashicorp/vault/blob/main/sdk/helper/cidrutil/cidr.go

fixed

@InfoHunter InfoHunter merged commit 5afb067 into Tongsuo-Project:main May 9, 2024
6 checks passed
wa5i pushed a commit to wa5i/RustyVault that referenced this pull request Dec 25, 2024
Added the  implementation of the salt and the CIDR tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants