-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the implementation of the salt and the CIDR tool. #51
Conversation
What is the use case of those newly added tool moduels? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, is all code being reviewed original? Otherwise we need to declare the origination of the code.
The approle module to be submitted later will use these two tools. |
These codes refer to the Golang implementation of Vault. In this case, do we still need to declare the source? |
Where is the original Golang implementation? |
https://github.com/hashicorp/vault/blob/main/sdk/helper/salt/salt.go |
You may add something like this to the beginning of the file:
And:
|
fixed |
Added the implementation of the salt and the CIDR tool.
No description provided.