Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some obvious typos #36

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

varshard
Copy link
Contributor

Fix some obvious typos.

Spotted some typos while reading documents. So, I decided to correct them while I'm at it.

@varshard
Copy link
Contributor Author

varshard commented Dec 19, 2023

Suggestiong, it would be nice if we use 1. for evevery numbered item as GitHub and most of the markdown renderers are smart enough to change them properly.

1. this is first
1. this is second

will be rendered as following automatically.

1. this is first
2. this is second

Copy link
Collaborator

@wa5i wa5i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the feedback!

@InfoHunter
Copy link
Member

Seems I should use VIM to check typos before commit the files. Thanks for the fixes

@InfoHunter InfoHunter merged commit ad9f604 into Tongsuo-Project:main Dec 20, 2023
3 checks passed
@InfoHunter
Copy link
Member

Suggestiong, it would be nice if we use 1. for evevery numbered item as GitHub and most of the markdown renderers are smart enough to change them properly.

Yes, I will address that later in another pull request.

@InfoHunter
Copy link
Member

Hi @varshard , we add a CLA file to RustyVault, so would you please sign that file online to make sure you agree with the statements?

@InfoHunter
Copy link
Member

It seems you can utilize this link: https://cla-assistant.io/Tongsuo-Project/RustyVault

wa5i pushed a commit to wa5i/RustyVault that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants