Added getNeighbourPawns method and implemented Retribution prayer logic #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisSnijder
suggested changes
Apr 30, 2019
| if (Prayers.isActive(player, Prayer.RETRIBUTION)) { | ||
| val targets = player.getNeighbourPawns() | ||
| for (target in targets) { | ||
| if (!target.isDead()) { |
There was a problem hiding this comment.
Would rater see something like if (target.isDead()) { continue; }.
this probably makes it a bit more readable and prevents from stacking indentions.
| target.hit(damage = (player.getSkills().getCurrentLevel(Skills.PRAYER) / 4)) | ||
| } else if (target is Npc) { | ||
| if (target.isSpawned() && target.def.isAttackable() && target.lock.canBeAttacked()) { | ||
| player.graphic(437) |
There was a problem hiding this comment.
Both statements for players and npc's are identical, perhaps do something at the start of the loop like target is not NPC || target is not Player => continue and execute the code beneath there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done?
Added utility method to find all neighboring pawns surrounding a target pawn
Implemented Retribution prayer logic, still needs to account for players being pvp attackable
This closes #108