fix(chatform): Remove assertion that breaks friend information call. #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
iphydf
reviewed
Jan 27, 2025
iphydf
approved these changes
Jan 29, 2025
nickolay168
force-pushed
the
nickolay168_fix_get_details
branch
from
d6c11b3 to
f1540fa
Compare
iphydf
approved these changes
Jan 29, 2025
|
Thanks, can you rebase on master? Then we can merge it. |
…tails is being called.
nickolay168
force-pushed
the
nickolay168_fix_get_details
branch
from
f1540fa to
1a04870
Compare
Done! Thank you! |
|
Can you sign your commit? We can't merge otherwise. I can't sign it for you because your fork is of qTox/qTox, not TokTok/qTox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are removing the assertion that the logging is on, when user tries to get the friend information. This assertion causes qTox failure when the logging is switched off.
This change is