18 token #28
Merged
18 token #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiwon-Woo
reviewed
Dec 13, 2023
sideseal
approved these changes
Dec 13, 2023
| if (refreshToken) { | ||
| await this.userService.updateRefreshToken(userId, refreshToken); |
There was a problem hiding this comment.
이 부분도 비동기 함수가 있는데 try-catch로 감싸는게 어떨까요...?!?
| refreshToken: string, | ||
| userUid: number, | ||
| ): Promise<UserEntity | null> { | ||
| const user: UserEntity | null = await this.findOneByUid(userUid); |
| userUid: number, | ||
| refreshToken: string, | ||
| ): Promise<void> { | ||
| const hashedRefreshToken: string = |
| } | ||
|
|
||
| async deleteRefreshToken(userUid: number): Promise<void> { | ||
| await this.userRepository.deleteRefreshToken(userUid); |
| refreshToken: string, | ||
| refreshTokenExpiredAt: Date, | ||
| ): Promise<void> { | ||
| const user: UserEntity = await this.findOneByUid(id); |
src/auth/guard/jwt.guard.ts
Outdated
| @@ -12,18 +12,13 @@ export class JwtGuard extends AuthGuard('jwt') { | |||
| async canActivate(context: ExecutionContext): Promise<boolean> { | |||
| if (context.getType() === 'http') { | |||
| this.logger.debug( | |||
| `canActivate [http, ${context.getArgs()[0].method} ${ | |||
There was a problem hiding this comment.
CPP 모듈 05를 끝내서 그런지 try-catch를 자꾸 감싸고 싶어지네요...
Jiwon-Woo
reviewed
Dec 13, 2023
| } | ||
|
|
||
| private async hashedRefreshToken(refreshToken: string): Promise<string> { | ||
| const saltRounds = 10; |
There was a problem hiding this comment.
saltRounds 해싱할 때도 쓰니까 공통 파일로 빼도 편할거 같네요
Jiwon-Woo
approved these changes
Dec 13, 2023
Jiwon-Woo
added
bug
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
일단 refresh token 해결법은 다시 시도해보겠습니다.
그 외 access_token과 login api 가 제대로 동작하게끔 바뀌었습니다.