DependencyManager rework #81

Tishj · 2023-10-28T19:39:22Z

No description provided.

… together with a designated type alias

…n't be run yet because DropObject is recursive, we cant perform both the Old and New version..

… | also skip registering dependencies for database entries, they cant have dependencies and they can't have dependents, seems like wasted effort even without this change

…ip behavior

… comes to getting types and names

…new_obj name differs

… locking

… this is required in the DependencyManager when looking up the schema in the LookupEntry, if we're dropping the schema it will be already marked as deleted - but we still need to find the entries of the schema

This reverts commit 9e78949, reversing changes made to a594ecf.

…child relationship

… necessary

…n the entry, no need to do another look up anymore

…oth ownership semantics and blocking/non-blocking at the same time

…tions of this

…two types of flags (blocking|owned_by) and (ownership)

…s us to 0<->255

Tishj added 30 commits October 24, 2023 18:35

add some getters/setters, hide internals, link some 'idx_t' variables…

9919f22

… together with a designated type alias

use catalog_entry_t in more places

c584eb9

Merge branch 'catalog_set_cleanup' into dependency_set

9e78949

create catalog entries for dependency management

84b079e

avoid clang-tidy issue

1463eb5

writing the new implementation alongside the old implementation

32faa51

unsaved changes

c5e1f27

build the new version alongside the old one, it compiles, but this ca…

9b56436

…n't be run yet because DropObject is recursive, we cant perform both the Old and New version..

get rid of eraseobjectinternal

4ec2c9f

remove the old version

a153027

use CreateEntryInternal to skip the write lock, should always be held…

7d1d14f

… | also skip registering dependencies for database entries, they cant have dependencies and they can't have dependents, seems like wasted effort even without this change

fix some bugs, add some debug code, apparently break sequence ownersh…

0589a3a

…ip behavior

fix more bugs, introduced by me

8fd3cc5

making progress, using some getters/setters to avoid footguns when it…

9886d7b

… comes to getting types and names

for now only clean up dependencies in AlterObject if the old_obj and …

ba2f9a3

…new_obj name differs

passing all tests

e7896f6

remove EraseObject, it's no longer needed

5f86a44

get rid of the callbacks in the lookup, should be safer in regards to…

03e9e1e

… locking

use DropEntry instead of the Internal variant

975f01e

add the option to not ignore deleted entries in CatalogSet::GetEntry,…

bd25dae

… this is required in the DependencyManager when looking up the schema in the LookupEntry, if we're dropping the schema it will be already marked as deleted - but we still need to find the entries of the schema

remove DependencyManager from friend classes of CatalogSet

13cb836

remove unused catalogtype

aec4a8c

Revert "Merge branch 'catalog_set_cleanup' into dependency_set"

903d93d

This reverts commit 9e78949, reversing changes made to a594ecf.

revert unrelated changes

162eaca

perform dependency operations before grabbing locks

839b1cc

more messing around with locks

1d5af1d

add getters/setters for CatalogEntry, to better control the parent<->…

21aced2

…child relationship

Merge branch 'catalog_set_cleanup' into dependency_set

7e0e91c

identified issue caused by the EntryDropper, I think this is not even…

28560fb

… necessary

get rid of DependencySetCatalogEntry as a friend class of CatalogSet

9470c1d

Tishj added 29 commits November 21, 2023 15:06

add test for the (future?)bug fixed by previous commit

588e9ae

clean up

bb5b38e

reduce duplication

6e38cd0

fix issue identified in follow up branch

8feb7f7

let the typesystem help us a little bit more

c9fca06

we now store the DependencyType of both the reliant and the subject i…

97922a4

…n the entry, no need to do another look up anymore

cleaning

0b610f6

add the opposite methods as well

425d7e9

enum util regenerate

6a124c6

add back debug methods for dependencies/dependents

ea19994

we don't preserve OWNED BY on restart currently

14f7da2

delete default constructor

b7f4614

replace DependencyType with DependencyFlags, allows us to represent b…

1e8f3be

…oth ownership semantics and blocking/non-blocking at the same time

fixed ownership checking

574084a

tidy check

3768a53

this path is never true anymore, need to look deeper into the implica…

18999f3

…tions of this

untangle the big confusing function

32e2093

rename reliant back to dependent

c534578

rename from dependency -> subject in all places

0791bf5

rename CICompare -> CILessThan

c88c576

use charmap | add assertion for DependencyFlag ownership semantics

0137494

fromdependency -> fromsubject

054b397

add extra invariant check

8163e4b

more renaming

c1c3993

make the ownership semantics a little less confusing, separating the …

84cddc1

…two types of flags (blocking|owned_by) and (ownership)

buffer overflow, using (int) gives us a negative value, uint8_t limit…

73c68f3

…s us to 0<->255

fix oversight

f8ae946

Merge remote-tracking branch 'upstream/main' into dependency_set

f05137c

Merge remote-tracking branch 'upstream/main' into dependency_set

189d505

Tishj merged commit 7d5150c into main Dec 11, 2023
46 of 48 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DependencyManager rework #81

DependencyManager rework #81

Tishj commented Oct 28, 2023

DependencyManager rework #81

DependencyManager rework #81

Conversation

Tishj commented Oct 28, 2023