[Export/Import] Expand and clean up existing PR on main #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the catalog entries
…inders CatalogEntryRetriever, add tests with created types and dependencies created by them
… dependencies of the generated columns are registered as dependencies of the table
…, don't make any cross-catalog dependencies, detect and properly error when CREATE OR REPLACE statements depend on itself
…recreated by GetInfo in the CatalogEntry
…a deadlock, grab the catalog using the context
… catalog in scope
Tishj
commented
Oct 20, 2023
| @@ -37,21 +37,29 @@ ORDER BY ALL | |||
| 22 11 | |||
|
|
|||
| # drop the table the view is based on | |||
| statement ok | |||
| statement error | |||
There was a problem hiding this comment.
This is probably not the behavior we want, so we should allow test to be dropped if the only dependencies are views.
We do need to keep them as dependencies for the sake of exporting, the table has to be written before the view is written
Tishj
force-pushed
the
dependency_manager_logical_dependencies
branch
from
eab4c52 to
52d961f
Compare
|
This is reaaaaally weird: read_csv_glob test failing, should error, but it succeeds. |
[Union] Fix issue with keyword/quoted UNION member names.
…er_logical_dependencies
…logical_dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the requirement of
ClientContextin every CatalogEntry constructor.