[Python] Support replacement scan on table method
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time is a problem
Change API to pass frame lists instead of window setting.
# Conflicts: # src/core_functions/scalar/list/CMakeLists.txt # src/planner/binder/expression/bind_function_expression.cpp
Support the EXCLUDE modifiers for COUNT(*).
Use swap instead of copying.
Implement exclude syntax for array_agg and friends. Fix non-contiguous NULL detection.
# Conflicts: # src/core_functions/lambda_functions.cpp # src/function/scalar_function.cpp # src/include/duckdb/planner/expression/bound_lambda_expression.hpp # src/planner/expression/bound_lambdaref_expression.cpp # src/storage/serialization/serialize_parsed_expression.cpp
Feature: Fixed size list nested type (ARRAY)
Fix unused warning
Internal duckdb#215: Window EXCLUDE Functionality
Add `json_serialize_plan`, json_serialize_sql tweaks
…port_to_fuzzer Add create statement support to fuzzer
Fix for issue duckdb#8108: Random() in lambda
Fix Lambda Serialization
…lacement scans in the table method
Allow file_row_number with parquet schema option
CSV - Always run sniffer by default
[Python Dev] Import items lazily
…Tishj/duckdb into python_try_replacement_relation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by changing the TryReplacement code to produce a Relation instead, using GetTableRef to get the TableRef that was previously produced by this function.
The main change here is that previously Relations did a bind in their constructor, which would fail in TryReplacement because that itself is called in a Bind. Grabbing the ClientContextLock there would cause a deadlock.
Now we move this binding out to a separate Verify() method.
It might be a bit of a misnomer, because initially this was taught to only effect feedback loop to the user but while testing this seemed to also be required by execute logic.