Skip to content

Commit

Permalink
make note of the issue: CREATE_OR_REPLACE not working
Browse files Browse the repository at this point in the history
  • Loading branch information
Tishj committed Oct 24, 2023
1 parent 23c25c0 commit d7c17cf
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/catalog/dependency_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,12 @@ void DependencyManager::EraseObject(CatalogEntry &object) {
}

void DependencyManager::EraseObjectInternal(CatalogEntry &object) {
if (dependents_map.find(object) == dependents_map.end()) {
auto object_entry = Dependency(object);
if (dependents_map.find(object_entry) == dependents_map.end()) {
// FIXME: this no longer works for CREATE_OR_REPLACE
// since we can't determine if the entry here is the new or old one.
// We used to use the pointer for this, now we just use the identifiers

// dependencies already removed
return;
}
Expand Down

0 comments on commit d7c17cf

Please sign in to comment.