Skip to content

Commit

Permalink
fix bug with fetch
Browse files Browse the repository at this point in the history
  • Loading branch information
Tishj committed Jan 13, 2025
1 parent 68518b0 commit c018372
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/storage/compression/dict_fsst/decompression.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ string_t CompressedStringScanState::FetchStringFromDict(Vector &result, int32_t

auto str_ptr = char_ptr_cast(dict_pos);
if (is_fsst_encoded) {
return FSSTPrimitives::DecompressValue(decoder, *dictionary, str_ptr, string_len, decompress_buffer);
return FSSTPrimitives::DecompressValue(decoder, result, str_ptr, string_len, decompress_buffer);
} else {
// FIXME: the Vector doesn't seem to take ownership of the non-inlined string data???
return string_t(str_ptr, string_len);
Expand Down
2 changes: 1 addition & 1 deletion test/sql/storage/compression/compression_selection.test
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ CHECKPOINT
query I
SELECT compression FROM pragma_storage_info('test_dict') WHERE segment_type ILIKE 'VARCHAR' LIMIT 1
----
Dictionary
DICT_FSST

# This test defaults to another compression function for smaller block sizes,
# because the bitpacking groups no longer fit the blocks.
Expand Down

0 comments on commit c018372

Please sign in to comment.