fix tidy issues and warnings-as-errors

Tishj · Dec 13, 2024 · 78a8abc · 78a8abc
1 parent 427ccc8
commit 78a8abc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/include/duckdb/storage/compression/dictionary/common.hpp b/src/include/duckdb/storage/compression/dictionary/common.hpp
@@ -35,7 +35,7 @@ struct DictionaryCompression {
 class DictionaryCompressionState : public CompressionState {
 public:
 	explicit DictionaryCompressionState(const CompressionInfo &info);
-	virtual ~DictionaryCompressionState();
+	~DictionaryCompressionState() override;
 
 public:
 	bool UpdateState(Vector &scan_vector, idx_t count);

diff --git a/src/storage/compression/dictionary/decompression.cpp b/src/storage/compression/dictionary/decompression.cpp
@@ -90,8 +90,6 @@ void CompressedStringScanState::ScanToFlatVector(Vector &result, idx_t result_of
 
 void CompressedStringScanState::ScanToDictionaryVector(ColumnSegment &segment, Vector &result, idx_t result_offset,
                                                        idx_t start, idx_t scan_count) {
-	auto result_data = FlatVector::GetData<string_t>(result);
-
 	D_ASSERT(start % BitpackingPrimitives::BITPACKING_ALGORITHM_GROUP_SIZE == 0);
 	D_ASSERT(scan_count == STANDARD_VECTOR_SIZE);
 	D_ASSERT(result_offset == 0);

diff --git a/src/storage/compression/dictionary_compression.cpp b/src/storage/compression/dictionary_compression.cpp
@@ -150,7 +150,7 @@ void DictionaryCompressionStorage::StringFetchRow(ColumnSegment &segment, Column
 	// fetch a single row from the string segment
 	CompressedStringScanState scan_state(state.GetOrInsertHandle(segment));
 	scan_state.Initialize(segment, false);
-	scan_state.ScanToFlatVector(result, result_idx, row_id, 1);
+	scan_state.ScanToFlatVector(result, result_idx, static_cast<idx_t>(row_id), 1);
 }
 
 //===--------------------------------------------------------------------===//