deal with the case where only the validity changes

Tishj · Jan 7, 2025 · 4de030f · 4de030f
1 parent 3848664
commit 4de030f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/include/duckdb/storage/table/column_data_checkpointer.hpp b/src/include/duckdb/storage/table/column_data_checkpointer.hpp
@@ -74,6 +74,7 @@ class ColumnDataCheckpointer {
 	void WritePersistentSegments(ColumnCheckpointState &state);
 	void InitAnalyze();
 	void DropSegments();
+	bool ValidityCoveredByBasedata(vector<CheckpointAnalyzeResult> &result);
 
 private:
 	vector<reference<ColumnCheckpointState>> &checkpoint_states;

diff --git a/src/storage/table/column_data_checkpointer.cpp b/src/storage/table/column_data_checkpointer.cpp
@@ -274,10 +274,14 @@ void ColumnDataCheckpointer::DropSegments() {
 	}
 }
 
-static bool ValidityCoveredByBasedata(vector<CheckpointAnalyzeResult> &result) {
+bool ColumnDataCheckpointer::ValidityCoveredByBasedata(vector<CheckpointAnalyzeResult> &result) {
 	if (result.size() != 2) {
 		return false;
 	}
+	if (!has_changes[0]) {
+		// The base data had no changes so it will not be rewritten
+		return false;
+	}
 	auto &base = result[0];
 	D_ASSERT(base.function);
 	return base.function->validity == CompressionValidity::NO_VALIDITY_REQUIRED;