-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having Issues compiling to apk in Android Studio #157
base: master
Are you sure you want to change the base?
Conversation
fix for shader compilation error on mac
Allows CMake to find system hidapi.
The flag -std=c++11 is needed for xBRZ to compile but it is not correctly passed by CMake, at least in macOS. Added it to the corresponding CMakeLists.txt The flag is added if compiling under macOS or Linux.
This also adds the flag when compiling under Linux as well as macOS.
Compilation fixes
by rebasing i mean base your changes on the latest version of ishiiruka instead of v6. |
I didn't even know that there was a new version of Ishiiruka for Android! |
the andoird codebase is present in the latest version on Master repository but i never tryed to build it because of my lack of time. i'm aware that it needs fixes to work, if your are willing to help me we can fix it and make it work. |
Right now I solved the issues with Android Studio not finding the NDK and having configuration issues when loading the build.gradle and it loads easily now BUT whenever I try to build the apk, I get the same set of build errors I that I mentioned here: https://stackoverflow.com/questions/62054559/errors-when-gradle-building-an-apk-from-source-code-need-help-or-guidance I'm hoping I can find the answer to solving those errors but since I'm learning about Android Studio, C++ coding and Java on my own (100% novice) .... All I can say is that I'll do my best~ Honestly, It can get a little frustrating because right now, without any fixes applied, I can't even build the apk with its own files from github. Meaning my progress is still at 0% with ishiiruka or barely close to 50%. I just need to be able to build the apk ..... [Update] externalNativeBuild { The apk gets built without issues but when you install it, open it and give it access to storage --> it will crash immediately and continue to crash whenever you attempt to open it. So I'm a little closer to identifying what the error is but still not sure. What do you think it might be? |
No matter what I do, I still run into this compilation error: org.gradle.internal.UncheckedException: compilation command failed. I have downloaded all the plugins for it but still not sure why it is not compiling the apk. |
can you share the fuill build log? |
Well everything should be in here: Thanks in advance for any guidance! |
Better yet are you able to compile the master version on github to an apk? I have yet to be able to compile the source code to an apk ... I keep running into various errors and even when I change things in the Android/app/build.gradle I just get a new set of errors during the build. |
Never tryed to compile ishiiruka to android, but looking at your error log it seems that you have a modified version of ishiiruka because i see code that is not on ishiiruka anymore. are you able cto compile your code for windows? |
I am using the exact code straight from github .... downloaded the zip file and opened the gradle build here: (Source/Android/build.gradle) ---> then it opens in Android Studio and loads --> then I clicked build --> generate signed bundle/Apk --> selected APK (signed) --> made a new keystore path + password --> Selected Build variant as "release" --> selected signature version as both V1 (Jar Signature) and V2 (Full Apk signature) --> Clicked Finish to run the building process (just like I did for MMJ) ......After about a minute or less; the build fails with an error(s). I haven't modified anything ...all I want to do is build the apk with its original files and once I can build it WITHOUT any modifications then I will attempt to apply my fixes or edit the files. That's what I did with MMJ as well; I made sure it could be built properly first before editing anything. Also, I did say in the beginning that I wanted to make an apk (ie. an android app version of Ishiiruka); which there is already one online but no source code given. The person who successfully made it/ edited it (I honestly don't know what he did to create it) said he used Ishiiruka master to do it. Unfortunately for me he only speaks Spanish and it doesn't seem like he wants to readily divulge his methods to me either and that's why I'm contacting you for guidance.... His exact translated words in response to where he got his source: When I told him about the errors and what he did to build the apk he responded with this: So far no more responses from him and that's since 30th May 2020. I have followed all compilation instructions hence, me being able to compile MMJ but Ishiiruka is just not working out. He also has a youtube channel showcasing Ishiiruka App/Apk here: https://www.youtube.com/watch?v=ht7Jn8C9iMk (it just doesn't have the fixes I want to apply) |
found the problem will try to fix it and cheking the changes when i have a little free time. |
OMG REALLY!!!?? |
compilation should be fixed. |
Thanks for the update; I'm trying to open the "build.gradle" to load it before building the apk but running into this error: I think when you updated the files, they weren't public released files? Not sure why that's happening but since its not loading because of that I'll have to look into it. I'll keep you posted! |
you need to create thaht file and configure the path and credential for your key store |
So after quite a while, I was FINALLY, able to build the apk !!! Thanks for all the hard work so far BUT one more issue came up after it was built ..... for some reason, even if I give the app "storage permissions", it doesn't allow me to see any folders/sub-folders in internal storage + SD card. You can see the issue here: I will try to see if I can take a page out of that "Cholodroid" guy who made the unofficial ishiiruka v6 apk and use Dolphin MMJ as a reference to try and fix the issue but if you know what the problem is then could you please fix the files whenever you are free? Without access to either internal or external storage (via SD card) I can't run games to test them .... far less, tweak the emulator with new fixes despite finally building the apk ... There is a possibility that I could have built it incorrectly or with errors; I'm not sure but if you run into the same issues then let me know~ |
tha is werir is working perfectly on my phone, can you try using this apk? |
Says I need access. If your apk works then it must be something on my end so I'll have to check it out for sure but yea, need that access please and thanks~ |
sorry the other link was wrong try this |
Thanks for the share. I responded to you with an reply email but I'll post what I said here as well:
One last thing to mention is that my device I'm testing everything on is a Pocophone F1 (rooted) with a custom Rom + kernel with the latest Adreno GPU Drivers v464.0. I doubt that would affect Ishiiruka but I'll mention it in the event that maybe the problem (All emulators work on my set up as well including all other versions of Dolphin - Official/MMJ/Ishiiruka (other)/ Mod)" |
Ok , will test in the Android emulator, because in my Remi note 7 it works by just installing and Allowing the app to acces the storage. |
Weird right? We're both building the Release versions but not all devices can use it ... [Update]
So I will try to rebuild the device with Android 10 as the max target to see if there are any changes but other than that do you have any idea on how to give compatibility to custom roms? (Never really had such an issue before) |
folder browsing should be fixed in thelatest version. |
Ok I think it might be related to my device running a custom rom but I fail to understand why every other emulator works including every dolphin variant (Official/MMJ/Ishiiruka (other)/Mod) except this one .... |
sorry it was my fault, forgot to push the changes now should be fixed. |
YES !!!! Just built it and file browser is working ! Again, thanks for all the hard work on getting the emulator Android Ready and following up with me consistently and quickly to get it there despite your busy schedule! [Update]
So that's just the pre-investigation into the build and I'll be working to see if I can tackle those issues and fix or improve them so wish me luck. If you ever update the source code with any fixes to these let me know and I'll retest things. |
the touch screen controls for me need to be relocated to work, about the other issues Im aware, those are missing functionalities from master, Will be gladd to merge those fixes if you make the pull request, Wiill let you know if i willl change something to avoid conflicts. |
No problem and I'll do the same ~ |
I want to give the Ishiiruka custom app (purple one) the same toggle function as seen in the Dolphin apk. I'm doing tests using the other apps before doing a complete overhaul on the Ishiiruka you updated. Please let me know of any ideas~ |
Any updates about this? |
I'm trying to update Ishiiruka with some fixes and I have already tested them with the older available source code of MMJ. I wanted to apply them to Ishiiruka to see if it would work as well since your Ishiiruka build is the main emulator I'm using.
So far I have been able to get Call of Duty Black Ops Zombies mode to work on the unofficial build after recompiling as you'll see here: https://www.youtube.com/watch?v=O0Md1-lltso
However when trying to generate the apk file in Android Studio with or without the fix I run into errors. You can see all here: https://stackoverflow.com/questions/62054559/errors-when-gradle-building-an-apk-from-source-code-need-help-or-guidance
I'm really fond of the Ishiiruka build and want to play Zombies mode on it and do more testing to see if I can update it as well or at least trial and error. I wanted to know if its possible that you can assist me with some guidance on how to generate the apk with Android Studio or correct the errors I'm getting?
I have no intention of making the app my own but I do want to update it and make other users more aware of Ishiiruka build.
Please contact me at [email protected].