Remove deprecated fields (#901)

* rm deprecated fields

* upgrade dependencies

---------

Co-authored-by: Aleks G <[email protected]>

package.json

@@ -34,25 +34,25 @@
     "prepare": "yarn run compile"
   },
   "dependencies": {
-    "axios": "^1.7.4",
-    "typescript": "^5.4.3"
+    "axios": "^1.7.9",
+    "typescript": "^5.7.3"
   },
   "devDependencies": {
-    "@eslint/compat": "^1.0.3",
-    "@types/jest": "^29.5.12",
-    "@typescript-eslint/eslint-plugin": "^7.12.0",
-    "@typescript-eslint/parser": "^7.12.0",
-    "axios-mock-adapter": "^1.22.0",
+    "@eslint/compat": "^1.2.5",
+    "@types/jest": "^29.5.14",
+    "@typescript-eslint/eslint-plugin": "^8.19.1",
+    "@typescript-eslint/parser": "^8.19.1",
+    "axios-mock-adapter": "^2.1.0",
     "cross-env": "^7.0.3",
-    "eslint": "^9.4.0",
+    "eslint": "^9.18.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-import": "^2.31.0",
     "husky-v4": "^4.3.8",
     "jest": "^29.7.0",
-    "lint-staged": "^15.2.0",
-    "prettier": "^3.2.5",
-    "ts-jest": "^29.1.1",
-    "typescript-eslint": "^7.12.0"
+    "lint-staged": "^15.3.0",
+    "prettier": "^3.4.2",
+    "ts-jest": "^29.2.5",
+    "typescript-eslint": "^8.19.1"
   },
   "husky": {
     "hooks": {

src/absenceTypes/index.ts

@@ -7,7 +7,7 @@ import { AbsenceTypeCreate, AbsenceTypeUpdate } from './types';
 const resourceName = 'absenceTypes';
 type ResourceName = typeof resourceName;
 export class AbsenceTypesEndpoint extends BaseApi<typeof resourceName> {
-  public readonly resourceName = 'absenceTypes';
+  public readonly resourceName = resourceName;
 
   public create(
     data: AbsenceTypeCreate,

src/authentication/index.ts

@@ -60,14 +60,20 @@ export class AuthenticationEndpoint extends BaseApi<any> {
       return axios.post<TokenResponse>(url, new URLSearchParams(credentials), config);
     }
 
-    throw objectCheck(
+    const objectCheckResult = objectCheck(
       {
         client_id: this.config.settings.clientId,
         client_secret: this.config.settings.clientSecret,
         refresh_token: refreshToken,
       },
       'Missing data for:',
     );
+
+    if (objectCheckResult) {
+      throw objectCheckResult;
+    } else {
+      throw new Error('Unknown refresh token error');
+    }
   }
 
   async login(credentials: Credentials): Promise<{ accessToken: string; refreshToken: string }> {

src/baseApi.ts

@@ -42,7 +42,7 @@ export type ApiConfig = {
   apiPrefix?: string;
   onServerTimeDeviationChange?: (deviation: number) => void;
   canonicalTimeUpdater?: (serverTimeZone: string, serverRequestEndTime: string) => void;
-  getChangedOnlyConfig?: (loggedInUser: User, since?: string | undefined) => DeltaSyncParams;
+  getChangedOnlyConfig?: (loggedInUser: User, since?: string) => DeltaSyncParams;
   customRequestHeaders?: { [key: string]: string };
 };
 

src/generalSettings/index.ts

@@ -8,7 +8,7 @@ const resourceName = 'generalSettings';
 type ResourceName = typeof resourceName;
 
 export class GeneralSettingsEndpoint extends BaseApi<ResourceName> {
-  public readonly resourceName = 'generalSettings';
+  public readonly resourceName = resourceName;
 
   public readBySettingType(settingType: string): Required<ResourceName, Entity<ResourceName>[]> {
     const params = new RequestParamsBuilder<GeneralSetting>().eq('setting_type', settingType).build();

src/integrationCategories/types.ts

@@ -1,14 +1,8 @@
-// Fields externalId, iconUrl, createdAt, updatedAt will be deprecated.
-// Use unique_id, icon_url, created_at, updated_at instead.
 export type IntegrationCategory = {
   id: number;
   title: string;
-  externalId?: string;
   unique_id: string;
-  iconUrl?: string;
   icon_url?: string;
-  createdAt?: string;
   created_at?: string;
-  updatedAt?: string;
   updated_at?: string;
 };

src/integrations/types.ts

@@ -1,23 +1,14 @@
-// Fields shortDescription, websiteUrl, navigationUrl, imageUrl, accessCredentialsId, createdAt, updatedAt will be deprecated.
-// Use short_description, website_url, navigation_url, image_url, access_credentials_id, created_at, updated_at instead.
 export type Integration = {
   id: number;
   title: string;
-  shortDescription?: string;
   short_description?: string;
-  websiteUrl?: string;
   website_url?: string;
-  navigationUrl?: string;
   navigation_url?: string;
-  imageUrl?: string;
   image_url?: string;
   featured?: boolean;
   provider?: string;
   application?: string;
-  accessCredentialsId?: number | null;
   access_credentials_id?: number | null;
-  createdAt?: string;
   created_at?: string;
-  updatedAt?: string;
   updated_at?: string;
 };

src/integrationsToCategories/types.ts

@@ -1,13 +1,7 @@
-// Fields integrationId, categoryId, createdAt, updatedAt will be deprecated.
-// Use integration_id, category_id, created_at, updated_at instead.
 export type IntegrationToCategory = {
   id: number;
-  integrationId?: number;
   integration_id?: number;
-  categoryId?: number;
   category_id?: number;
-  createdAt?: string;
-  updatedAt?: string;
   created_at?: string;
   updated_at?: string;
 };

src/tasks/index.ts

@@ -8,7 +8,7 @@ const resourceName = 'tasks';
 type ResourceName = typeof resourceName;
 
 export class TasksEndpoint extends BaseApi<ResourceName> {
-  public readonly resourceName = 'tasks';
+  public readonly resourceName = resourceName;
 
   public create(data: TaskCreate, params?: RequestParams<Entity<ResourceName>>): Required<ResourceName> {
     const response = this._post<ResourceName>('create', data, params);

src/timesheetAccountingSummaries/index.ts

@@ -8,7 +8,7 @@ const resourceName = 'timesheetAccountingSummaries';
 type ResourceName = typeof resourceName;
 
 export class TimesheetAccountingSummariesEndpoint extends BaseApi<'timesheetAccountingSummaries'> {
-  public readonly resourceName = 'timesheetAccountingSummaries';
+  public readonly resourceName = resourceName;
 
   public readTimesheetAccountingSummaries(
     params?: RequestParams<TimesheetAccountingSummariesRead> | string,

src/users/index.ts

@@ -30,19 +30,19 @@ import {
 } from './types';
 
 const resourceName = 'users';
-const usersReadMe = 'usersReadMe';
+type UsersReadMe = 'usersReadMe';
 type ResourceName = typeof resourceName;
 
 export class UsersEndpoint extends BaseApi<ResourceName> {
-  public readonly resourceName = 'users';
+  public readonly resourceName = resourceName;
 
-  public readMe(params?: RequestParams<UserReadMe>): Required<typeof usersReadMe> {
-    const response = this._get<typeof usersReadMe>('me', { params });
+  public readMe(params?: RequestParams<UserReadMe>): Required<UsersReadMe> {
+    const response = this._get<UsersReadMe>('me', { params });
     return requiredSingle(response);
   }
 
   public async readMeRaw(params: RequestParams<UserReadMe>): Promise<ReadRawResponse<UserReadMe>> {
-    const response = this._get<typeof usersReadMe>('me', { params });
+    const response = this._get<UsersReadMe>('me', { params });
     return createReadRawResponse<UserReadMe>(createResourceResponse(await createRawApiResponse(response)), params);
   }
 

src/utils/index.ts

@@ -13,9 +13,9 @@ type Data = {
  * @param {string} prefix = undefined prefix of message
  * @param {string} postfix = undefined postfix of message
  *
- * @return {string} message
+ * @return {Error | null} message
  */
-export const objectCheck = (data: Data, prefix?: string, postfix?: string): string => {
+export const objectCheck = (data: Data, prefix?: string, postfix?: string): Error | null => {
   let message = ''; //: string = `${prefix || ''}`;
 
   for (const key in data) {
@@ -32,7 +32,7 @@ export const objectCheck = (data: Data, prefix?: string, postfix?: string): stri
     }
   }
 
-  return message;
+  return message ? new Error(message) : null;
 };
 
 export class ConfigProvider {

src/utils/response/rawApiResponse.ts

@@ -53,6 +53,7 @@ export async function createRawApiResponse(promise: Promise<AxiosResponse>): Pro
     if (error.response?.data != null && typeof error.response.data === 'object' && hasSuccessProperty(error.response.data)) {
       axiosResponse = error.response;
     } else {
+      //eslint-disable-next-line @typescript-eslint/only-throw-error
       throw {
         _plainError: error,
         message: error.message,
@@ -68,6 +69,7 @@ export async function createRawApiResponse(promise: Promise<AxiosResponse>): Pro
   } else {
     const optionalResponse = axiosResponse.data as ApiResponseOnFailure | undefined;
 
+    //eslint-disable-next-line @typescript-eslint/only-throw-error
     throw {
       response: optionalResponse,
       _plainError: axiosResponse,

src/utils/response/responseHandlers.ts

@@ -96,6 +96,7 @@ async function resolveResponse<ResourceName extends ResourceNames>(
     if (error.response?.data != null && typeof error.response.data !== 'string' && hasSuccessProperty(error.response.data)) {
       resolved = error.response as AxiosResponse<ApiResponse<ResourceName>> | AxiosResponse<ApiBatchResponse<ResourceName>>;
     } else {
+      //eslint-disable-next-line @typescript-eslint/only-throw-error
       throw {
         _plainError: error,
         message: error.message,
@@ -117,6 +118,7 @@ export async function toApiBatchResponse<ResourceName extends ResourceNames>(
     return apiResponse;
   }
 
+  //eslint-disable-next-line @typescript-eslint/only-throw-error
   throw getParsedErrorMessageObject(apiResponse, resolved);
 }
 
@@ -140,6 +142,7 @@ export async function toApiResponse<ResourceName extends ResourceNames>(
     return apiResponse;
   }
 
+  //eslint-disable-next-line @typescript-eslint/only-throw-error
   throw getParsedErrorMessageObject(apiResponse, resolved);
 }