Delete me offset #68
Merged
Delete me offset #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FL3SH I didn't seem to get an email for this glorious change! |
brandoncc
reviewed
Jul 8, 2020
| ); | ||
| console.log("delete-round#getColumnOffset - userOffset ", offset); | ||
| } else { | ||
| offset = Math.floor(Math.random() * (40 - 5)) + 5; |
There was a problem hiding this comment.
@ThePrimeagen @FL3SH this line will overwrite the value set on line 27, won't it?
There was a problem hiding this comment.
aaa, my bad, of course offset = 3 will always be overwritten ;/
Tbh I personally like it way more with random offset event in 'noob' this is why I missed it.
Fixed in #70
|
I love the random offset.
Would it make sense if the minimum offset (+5) changed depending on the
difficulty? Say the harder the bigger the minimum offset..?
|
|
I am not sure about that. Can you open an issue about that, so we can discuss it? |
|
there it it: #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @brandoncc