fix typo in links-and-images.md in html-foundations #29310
Conversation
github-actions
bot
added
the
Content: Foundations
There was a problem hiding this comment.
I like this change, but your PR has a bunch of other formatting changes that seem to have been mistakenly added in. You'll have to undo all of these before I can approve.
To prevent this from happening in the future, make sure you disable any auto-formatting your editor does while working on the Markdown files in our curriculum.
|
I fixed it! It was caused by Prettier settings |
There was a problem hiding this comment.
There are still a lot of unrelated changes. If you click the Files changed tab at the top of this PR, you can see just how many formatting changes remain. Any change that isn't due to the typo needs to be taken out. Additionally, there's an accidental revert commit you have in here that we definitely don't want to merge in.
At this point I think it would be simplest to reset all of your changes and then add/commit the typo fix again. If you're not comfortable enough with git to do that, let me know, and I can provide some commands to run to help out.
height and width are attributes of img element (not tags on img element)
csm-18
force-pushed
the
html-links-and-images-edit
branch
from
72d30ea to
6d60420
Compare
|
Sorry for the mess! |
change 'tags' to 'attributes' when referring to weight and height attributes of img tag
This PR