Form Validation with JavaScript: Change Zip Code to Postal Code (TheOdinProject#29201) #29307
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Issue TheOdinProject#29201, a form that requires Country and Zip Code does not make sense, as ZIP codes are for United States addresses only. Postal Code is a related term that is understood and applicable in many countries. TheOdinProject#29201
linkonsat
requested review from
a team and
thatblindgeye
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Per Issue #29201, a form that requires Country and Zip Code does not make sense, as ZIP codes are for United States addresses only. Postal Code is a more general term that is understood and applicable in many countries.
This PR
Issue
Closes #29201
Additional Information
This is one of several possible fixes to the issue where Country and Zip Code don't make sense together. If anyone prefers keeping Zip Code and changing something else, let's discuss.
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection