You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In JavaScript in the Real World -> Form Validation with JavaScript, the practice assignment calls for making a form with the fields Email, Country, Zip Code, Password, and Password Confirmation. However, Country and Zip Code don't make sense as fields in the same form, as ZIP Codes are specific to the United States and its territories and aren't used in other countries. I recommend replacing Zip Code with Postal Code (the any-country general term) in this assignment.
If the purpose of including a ZIP Code specifically is to invite students to validate against a minimum and maximum or a simple pattern, then it could be kept as Zip Code sensibly under these conditions:
The Country field is changed to State or something else that makes sense for a US-specific form.
The constraints of a ZIP code are spelled out or linked for the sake of students who live outside the US.
Thanks for requesting attention on this issue, @CouchofTomato. Since we haven't heard back and it's been a few weeks, what I think I'll do is prepare a simple pull request that changes Zip Code to Postal Code where it is mentioned.
McKathlin
added a commit
to McKathlin/odin-project-curriculum
that referenced
this issue
Jan 10, 2025
Per Issue TheOdinProject#29201, a form that requires Country and Zip Code does not
make sense, as ZIP codes are for United States addresses only.
Postal Code is a related term that is understood and applicable in
many countries.
TheOdinProject#29201
Checks
Describe your suggestion
In JavaScript in the Real World -> Form Validation with JavaScript, the practice assignment calls for making a form with the fields Email, Country, Zip Code, Password, and Password Confirmation. However, Country and Zip Code don't make sense as fields in the same form, as ZIP Codes are specific to the United States and its territories and aren't used in other countries. I recommend replacing Zip Code with Postal Code (the any-country general term) in this assignment.
If the purpose of including a ZIP Code specifically is to invite students to validate against a minimum and maximum or a simple pattern, then it could be kept as Zip Code sensibly under these conditions:
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/node-path-javascript-form-validation-with-javascript
(Optional) Discord Name
McKathlin#2776
(Optional) Additional Comments
I'm equally happy to work on this issue or let someone else work on this issue; whatever is more convenient is fine!
The text was updated successfully, but these errors were encountered: