Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation with JavaScript: Country and Zip Code combination doesn't make sense #29201

Open
3 tasks done
McKathlin opened this issue Dec 16, 2024 · 2 comments · May be fixed by #29307
Open
3 tasks done

Form Validation with JavaScript: Country and Zip Code combination doesn't make sense #29201

McKathlin opened this issue Dec 16, 2024 · 2 comments · May be fixed by #29307

Comments

@McKathlin
Copy link

Checks

Describe your suggestion

In JavaScript in the Real World -> Form Validation with JavaScript, the practice assignment calls for making a form with the fields Email, Country, Zip Code, Password, and Password Confirmation. However, Country and Zip Code don't make sense as fields in the same form, as ZIP Codes are specific to the United States and its territories and aren't used in other countries. I recommend replacing Zip Code with Postal Code (the any-country general term) in this assignment.

If the purpose of including a ZIP Code specifically is to invite students to validate against a minimum and maximum or a simple pattern, then it could be kept as Zip Code sensibly under these conditions:

  • The Country field is changed to State or something else that makes sense for a US-specific form.
  • The constraints of a ZIP code are spelled out or linked for the sake of students who live outside the US.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-form-validation-with-javascript

(Optional) Discord Name

McKathlin#2776

(Optional) Additional Comments

I'm equally happy to work on this issue or let someone else work on this issue; whatever is more convenient is fine!

@CouchofTomato
Copy link
Member

@TheOdinProject/javascript Can someone review please

@McKathlin
Copy link
Author

McKathlin commented Jan 10, 2025

Thanks for requesting attention on this issue, @CouchofTomato. Since we haven't heard back and it's been a few weeks, what I think I'll do is prepare a simple pull request that changes Zip Code to Postal Code where it is mentioned.

McKathlin added a commit to McKathlin/odin-project-curriculum that referenced this issue Jan 10, 2025
Per Issue TheOdinProject#29201, a form that requires Country and Zip Code does not
make sense, as ZIP codes are for United States addresses only.
Postal Code is a related term that is understood and applicable in
many countries.
TheOdinProject#29201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants