Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nox): support Python 3.10 #315

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 3, 2021

Also install ssh & git to workaround flakiness when using this as a CircleCI image. pydata/pydata-google-auth#43

Also install ssh & git to workaround flakiness when using this as a CircleCI image. pydata/pydata-google-auth#43
@tswast tswast requested a review from TheKevJames as a code owner December 3, 2021 17:16
@@ -23,6 +25,9 @@ RUN apt-get update -qy && \
python3.9 \
python3.9-dev \
python3.9-distutils \
python3.10 \
python3.10-dev \
python3.10-distutils \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is needed, but I saw there was one for Python 3.9.

@karsil
Copy link

karsil commented Jan 27, 2022

Hi @tswast , did you managed to progress on this topic in the meantime?
I'm currently trying to bring this image to work on Gitlab CI to test for Python 3.10. As this PR is still open, did you find any alternative?

@TheKevJames Or could this be merged?

Thanks in advance!

@tswast
Copy link
Contributor Author

tswast commented Jan 27, 2022

Unfortunately, my workaround was to migrate away from this image. I'm using micromamba now and installing the necessary dependencies that way.

Edit: I still haven't migrated every repo. The pydata-google-auth repo tests still continue to fail.

Copy link
Owner

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the incredible delays on this, I've been remiss on my OSS maintenance work. Both the addition of py3.10 and the git/openssh-client adds looks just fine to me. Thanks for the PR!

@TheKevJames TheKevJames merged commit f180d7c into TheKevJames:master Mar 11, 2022
@tswast tswast deleted the patch-1 branch April 5, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants