Included tile spacing and margin in source rectangle calculation #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaltinril
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Similar to PR #86, as indicated by @treesgobark but this one has an additional fix it appear for the tileset boarder. Code makes sense to me, recommend merging if no unforseen issues exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DualStickSheet.zip
Saw the discussion on #86. Here's a solution that also includes the margins and a tilesheet to test with. Note how each tile is 16x16 but has a 1 pixel border around it that matches the adjacent pixel. Margin is the thickness of the border around the entire tile sheet image whereas spacing is how many pixels are between any two tiles. This "extrusion" is used for solving gpu rounding errors that try to sample from the sprite sheet a tiny bit over the true border of the sprite and end up creating strange lines between tiles. Aseprite has an extrude option when exporting a tile sheet that does this for you if you want to make your own. https://www.aseprite.org/docs/sprite-sheet/