Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLY bugfix #277

Closed
wants to merge 1 commit into from
Closed

TLY bugfix #277

wants to merge 1 commit into from

Conversation

ArdenHide
Copy link
Member

No description provided.

@ArdenHide ArdenHide self-assigned this Oct 10, 2024
Copy link

Diagrams

Diagrams summary
URL PATH
include URL ./diagrams/include.puml
DateTimeExtensionsTests URL ./diagrams/tests/MetaDataAPI.Tests/Extensions/DateTimeExtensionsTests.puml
LockDealNftServiceExtensionsTests URL ./diagrams/tests/MetaDataAPI.Tests/Extensions/LockDealNftServiceExtensionsTests.puml
LambdaRequestTests URL ./diagrams/tests/MetaDataAPI.Tests/Request/LambdaRequestTests.puml
LambdaRequestValidatorTests URL ./diagrams/tests/MetaDataAPI.Tests/Validation/LambdaRequestValidatorTests.puml
Erc20ProviderTests URL ./diagrams/tests/MetaDataAPI.Tests/Services/Erc20/Erc20ProviderTests.puml
Erc20TokenTests URL ./diagrams/tests/MetaDataAPI.Tests/Services/Erc20/Erc20TokenTests.puml
LambdaFunction URL ./diagrams/src/MetaDataAPI/LambdaFunction.puml
Environments URL ./diagrams/src/MetaDataAPI/Environments.puml
DefaultServiceProvider URL ./diagrams/src/MetaDataAPI/DefaultServiceProvider.puml
DateTimeExtensions URL ./diagrams/src/MetaDataAPI/Extensions/DateTimeExtensions.puml
LockDealNftServiceExtensions URL ./diagrams/src/MetaDataAPI/Extensions/LockDealNftServiceExtensions.puml
LambdaRequest URL ./diagrams/src/MetaDataAPI/Request/LambdaRequest.puml
LambdaRequestValidator URL ./diagrams/src/MetaDataAPI/Validation/LambdaRequestValidator.puml
CollateralProvider URL ./diagrams/src/MetaDataAPI/Providers/CollateralProvider.puml
DelayVaultProvider URL ./diagrams/src/MetaDataAPI/Providers/DelayVaultProvider.puml
TimedDealProvider URL ./diagrams/src/MetaDataAPI/Providers/TimedDealProvider.puml
AbstractProvider URL ./diagrams/src/MetaDataAPI/Providers/AbstractProvider.puml
RefundProvider URL ./diagrams/src/MetaDataAPI/Providers/RefundProvider.puml
DealProvider URL ./diagrams/src/MetaDataAPI/Providers/DealProvider.puml
LockDealProvider URL ./diagrams/src/MetaDataAPI/Providers/LockDealProvider.puml
Erc721MetadataItem URL ./diagrams/src/MetaDataAPI/Providers/Attributes/Erc721MetadataItem.puml
DisplayType URL ./diagrams/src/MetaDataAPI/Providers/Attributes/DisplayType.puml
Erc721Metadata URL ./diagrams/src/MetaDataAPI/Providers/Attributes/Erc721Metadata.puml
Erc721MetadataItemAttribute URL ./diagrams/src/MetaDataAPI/Providers/Attributes/Erc721MetadataItemAttribute.puml
UrlifyProvider URL ./diagrams/src/MetaDataAPI/Providers/Image/UrlifyProvider.puml
QueryStringToken URL ./diagrams/src/MetaDataAPI/Providers/Image/QueryStringToken.puml
ChainNotSupportedResponse URL ./diagrams/src/MetaDataAPI/Response/ChainNotSupportedResponse.puml
PoolIdNotInSupplyRangeResponse URL ./diagrams/src/MetaDataAPI/Response/PoolIdNotInSupplyRangeResponse.puml
ValidationErrorResponse URL ./diagrams/src/MetaDataAPI/Response/ValidationErrorResponse.puml
SuccessResponse URL ./diagrams/src/MetaDataAPI/Response/SuccessResponse.puml
GeneralErrorResponse URL ./diagrams/src/MetaDataAPI/Response/GeneralErrorResponse.puml
LambdaResponse URL ./diagrams/src/MetaDataAPI/Response/LambdaResponse.puml
IChainManager URL ./diagrams/src/MetaDataAPI/Services/ChainsInfo/IChainManager.puml
ChainInfo URL ./diagrams/src/MetaDataAPI/Services/ChainsInfo/ChainInfo.puml
DbChainManager URL ./diagrams/src/MetaDataAPI/Services/ChainsInfo/DbChainManager.puml
Erc20Token URL ./diagrams/src/MetaDataAPI/Services/Erc20/Erc20Token.puml
IErc20Provider URL ./diagrams/src/MetaDataAPI/Services/Erc20/IErc20Provider.puml
Erc20Provider URL ./diagrams/src/MetaDataAPI/Services/Erc20/Erc20Provider.puml

Copy link

Summary

Summary
Generated on: 10/10/2024 - 12:43:58
Coverage date: 10/10/2024 - 12:43:58
Parser: Cobertura
Assemblies: 1
Classes: 28
Files: 28
Line coverage: 25.3% (97 of 383)
Covered lines: 97
Uncovered lines: 286
Coverable lines: 383
Total lines: 844
Branch coverage: 17.6% (6 of 34)
Covered branches: 6
Total branches: 34
Method coverage: Feature is only available for sponsors

Coverage

MetaDataAPI - 25.3%
Name Line Branch
MetaDataAPI 25.3% 17.6%
MetaDataAPI.DefaultServiceProvider 0% 0%
MetaDataAPI.Extensions.DateTimeExtensions 100%
MetaDataAPI.Extensions.LockDealNftServiceExtensions 100%
MetaDataAPI.LambdaFunction 0% 0%
MetaDataAPI.Providers.AbstractProvider 0% 0%
MetaDataAPI.Providers.Attributes.Erc721Metadata 0%
MetaDataAPI.Providers.Attributes.Erc721MetadataItem 0%
MetaDataAPI.Providers.Attributes.Erc721MetadataItemAttribute 0%
MetaDataAPI.Providers.CollateralProvider 0%
MetaDataAPI.Providers.DealProvider 0%
MetaDataAPI.Providers.DelayVaultProvider 0%
MetaDataAPI.Providers.Image.QueryStringToken 0%
MetaDataAPI.Providers.Image.UrlifyProvider 0% 0%
MetaDataAPI.Providers.LockDealProvider 0%
MetaDataAPI.Providers.RefundProvider 0%
MetaDataAPI.Providers.TimedDealProvider 0%
MetaDataAPI.Request.LambdaRequest 100% 100%
MetaDataAPI.Response.ChainNotSupportedResponse 0%
MetaDataAPI.Response.GeneralErrorResponse 0%
MetaDataAPI.Response.LambdaResponse 0% 0%
MetaDataAPI.Response.PoolIdNotInSupplyRangeResponse 0%
MetaDataAPI.Response.SuccessResponse 0%
MetaDataAPI.Response.ValidationErrorResponse 0% 0%
MetaDataAPI.Services.ChainsInfo.ChainInfo 100%
MetaDataAPI.Services.ChainsInfo.DbChainManager 0%
MetaDataAPI.Services.Erc20.Erc20Provider 100%
MetaDataAPI.Services.Erc20.Erc20Token 100%
MetaDataAPI.Validation.LambdaRequestValidator 100%

@ArdenHide ArdenHide requested a review from Lomet October 10, 2024 12:50
@ArdenHide
Copy link
Member Author

This lambda code has been deployed, but API still not updated.

@ArdenHide
Copy link
Member Author

AWS test:

request:

{
  "queryStringParameters": {
    "chainId": 1,
    "poolId": 0
  }
}

response:

{
  "statusCode": 200,
  "headers": {
    "Content-Type": "application/json"
  },
  "multiValueHeaders": null,
  "body": "{\"name\":\"Lock Deal NFT Pool: 0\",\"description\":\"This NFT securely locks 376000 units of the asset Winee3 ([email protected]). Access to these assets will commence on the designated start time of 07/01/2024 14:15:00.\",\"image\":\"https://t.ly/jXsON\",\"attributes\":[{\"display_type\":\"date\",\"trait_type\":\"start time\",\"value\":1719843300},{\"display_type\":\"string\",\"trait_type\":\"provider name\",\"value\":\"LockDealProvider\"},{\"display_type\":\"number\",\"trait_type\":\"collection\",\"value\":1},{\"display_type\":\"number\",\"trait_type\":\"left amount\",\"value\":376000.0}]}",
  "isBase64Encoded": false
}

@Lomet Lomet closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants