Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update umbrella header with all public headers #2104

Closed
wants to merge 2 commits into from

Conversation

rgnns
Copy link
Collaborator

@rgnns rgnns commented May 2, 2024

Fixes issues with incomplete umbrella header, and sorts the imports to make it more parseable.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gabriel Lievano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

#import <AsyncDisplayKit/ASImageNode.h>
#import <AsyncDisplayKit/ASImageProtocols.h>
#import <AsyncDisplayKit/ASInsetLayoutSpec.h>
#import <AsyncDisplayKit/ASInternalHelpers.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is in the Private. Including it here is leading to CI errors I think. From my local machine:

 In file included from <module-includes>:1:
    In file included from /Users/ricky/Library/Developer/Xcode/DerivedData/App-cmukoxucfrqoygfzczenwnzxbpno/Build/Products/Release-appletvsimulator/Texture/AsyncDisplayKit.framework/Headers/Texture-umbrella.h:72:
    /Users/ricky/Library/Developer/Xcode/DerivedData/App-cmukoxucfrqoygfzczenwnzxbpno/Build/Products/Release-appletvsimulator/Texture/AsyncDisplayKit.framework/Headers/AsyncDisplayKit.h:60:9: fatal error: 'AsyncDisplayKit/ASInternalHelpers.h' file not found
    #import <AsyncDisplayKit/ASInternalHelpers.h>
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/ricky/Library/Developer/Xcode/DerivedData/App-cmukoxucfrqoygfzczenwnzxbpno/Build/Products/Release-appletvsimulator/Texture/AsyncDisplayKit.framework/Headers/AsyncDisplayKit.h:60:9: note: did not find header 'ASInternalHelpers.h' in framework 'AsyncDisplayKit' (loaded from '/Users/ricky/Library/Developer/Xcode/DerivedData/App-cmukoxucfrqoygfzczenwnzxbpno/Build/Products/Release-appletvsimulator/Texture')
    1 error generated.
    /var/folders/l4/mwbclhpx2217w2dbqg70hsj00000gn/T/CocoaPods-Lint-20240503-60999-pasba3-Texture/App/main.m:3:9: fatal error: could not build module 'AsyncDisplayKit'
    @import AsyncDisplayKit;
     ~~~~~~~^~~~~~~~~~~~~~~
    2 errors generated.

@rgnns rgnns closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants