Make the Embargo Type and Submission Type None values configurable. #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of the case of `None` is treated as as synonymous with a NULL value for that field in the database. I've looked over the different use cases and have found that in some cases `Unknown` and `Unassigned` are used. Make this `None` filter value customizable rather than hard-coding the opinion of `None` being NULL. The `app.filter.embargoTypeNone` and `app.filter.submissionTypeNone` may now be changed to something other than `None`. The default remains set to `None`.
…Types filter code.
If the `EmbargoType` and `SubmissionType` `None` settings are not specified in the `application.yml` or via an environment variable then a `NULL` pointer exception no longer is thrown. When not configured, then the `None` settings are ignored entirely. When not configured, then the `None` searches do not match `NULL` but do match the string.
cstarcher
previously approved these changes
May 30, 2024
kaladay
dismissed
cstarcher’s stale review
The merge-base changed after approval.
cstarcher
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on and effectively includes the following PRs:
The behavior of the case of
Noneis treated as as synonymous with a NULL value for that field in the database. I've looked over the different use cases and have found that in some casesUnknownandUnassignedare used.Make this
Nonefilter value customizable rather than hard-coding the opinion ofNonebeing NULL.The
app.filter.embargoTypeNoneandapp.filter.submissionTypeNonemay now be changed to something other thanNone. The default remains set toNone.The following new
application.ymlsettings are now introduced:Their respective environment variable names are: