fix: Align MockDirectory and MockFile behavior with .NET's System.IO classes #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing files The MockDirectory class previously did not replicate the behavior of System.IO.Directory when calling the Delete method on a file path. In System.IO.Directory, an IOException is thrown if the specified path points to a file instead of a directory. This commit updates MockDirectory to ensure it throws an IOException in this scenario, maintaining consistency with the expected behavior of System.IO.Directory.
…ories The MockFile class previously did not replicate the behavior of System.IO.File when calling the Delete method on a directory path. In System.IO.File, an UnauthorizedAccessException is thrown if the specified path points to a directory instead of a file. This commit updates MockFile to ensure it throws an UnauthorizedAccessException in this scenario, maintaining consistency with the expected behavior of System.IO.File.
vbreuss
approved these changes
Jan 25, 2025
|
This is addressed in release v21.2.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MockDirectoryandMockFileclasses previously did not replicate the .NET behavior of throwing exceptions in the following scenarios:MockFile.MockDirectory.This pull request addresses these inconsistencies by updating the mocks to correctly throw exceptions in these cases, ensuring their behavior aligns with the corresponding
System.IOclasses they are designed to mimic.