Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalstretch support for custom levels #997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AllyTally
Copy link
Contributor

Changes:

This PR adds all of the necessary code to support finalstretch in custom levels, including a new command, finalstretch(on/off). This is visual.

This PR also changes the autotile fill for the gray warp zone to be tile 740, to support finalstretch better.

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes

Copy link
Contributor

@InfoTeddy InfoTeddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a regression of the bug that #682 (3c5ee78) fixed.

@AllyTally AllyTally marked this pull request as draft September 25, 2023 01:38
@InfoTeddy
Copy link
Contributor

At a glance, this looks okay. My only concern as of now is that people would be annoyed by changing the gray backing tile to 740 and that this would create a split in the look of auto-tiled gray Warp Zone rooms in custom levels before and after 2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants