1.21.4 porting #802
Merged
1.21.4 porting #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good enough lol, the entire UI is gonna be rewritten at some point anyway. needs some fresh code |
|
I checked over Placeholder already, so the 1.21.3 is fine for 1.21.4, no problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mod works as is for PRE2. There is a block of code that I couldn't get working right, so I just commented it out. It doesn't seem to effect anything from the Mod from working, but please verify what it's purpose was.
The reason it was commented out, was because it was removed from it's super class (
EntryListWidget) under Vanilla, and only able to @OverRide themouseClickedunderContainerWidget, which was causing an infinite loop; particularly concerning isclickedHeader(select now ?) where, the only Occurrence of this is underStatsScreen.ItemStatsListWidgetor else false.It's a situation where commenting it out was the easy solution that allows the mod to work, since the code that it was using was mostly removed from Vanilla.