Changed the eventing of archive location of monitoring data #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While un-manage cluster, the archive location was earlier being communicated through a notification. The same is changed to just log as an event as un-manage is always a user triggered action and and event with archive location details is sufficient tendrl-bug-id: Tendrl/notifier#157 Signed-off-by: Shubhendu <[email protected]>
|
@nthomas-redhat @r0h4n @julienlim plz review |
r0h4n
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While un-manage cluster, the archive location was earlier being
communicated through a notification. The same is changed to just
log as an event as un-manage is always a user triggered action
and and event with archive location details is sufficient
tendrl-bug-id: Tendrl/notifier#157
Signed-off-by: Shubhendu [email protected]