feat: sync tenant infor to the desktop when creating app (including light apps) #1885
+68
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgetx
reviewed
Jan 16, 2025
| @@ -25,6 +26,9 @@ class LightAppCreateSLZ(serializers.Serializer): | |||
| app_name = serializers.CharField( | |||
| required=True, allow_blank=False, max_length=20, help_text="轻应用名称", source="name" | |||
| ) | |||
| app_tenant_mode = serializers.ChoiceField( | |||
There was a problem hiding this comment.
现在都这么定义了，不使用 ChoiceField，减少后续 choices 变化带来的 migration 变动
app_tenant_mode = models.CharField(
verbose_name="应用租户模式",
max_length=16,
default=AppTenantMode.GLOBAL.value,
help_text="应用在租户层面的可用范围，可选值：全租户、指定租户",
)
There was a problem hiding this comment.
这个是 slz ，不是 model 定义，用 ChoiceField 方便生成 swagger api 文档
piglei
approved these changes
Jan 16, 2025
| @@ -163,6 +167,18 @@ def create( | |||
| migrated_to_paasv3=0, # 是否已经迁移到Paas3.0 | |||
| open_mode="new_tab", # 应用打开方式, desktop: 桌面打开, new_tab: 新标签页打开 | |||
| ) | |||
| # 桌面的应用表里面已经定义了租户相关字段，则写入 | |||
| if hasattr(self.model, "app_tenant_mode"): | |||
| @@ -25,6 +26,9 @@ class LightAppCreateSLZ(serializers.Serializer): | |||
| app_name = serializers.CharField( | |||
| required=True, allow_blank=False, max_length=20, help_text="轻应用名称", source="name" | |||
| ) | |||
| app_tenant_mode = serializers.ChoiceField( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需要先合入 TE 分支的相关的 PR，再跑单测
checklist: