bug：流水线描述内容过长导致编辑后发布报错500 #11404 #11411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 29446
# Reviewed, transaction id: 29453
vhwweng
requested review from
lockiechen,
terlinhe and
zhanxu33
as code owners
# Reviewed, transaction id: 29454
lockiechen
reviewed
Jan 17, 2025
| }, | ||
| maxlength: { | ||
| type: String, | ||
| default: '' |
There was a problem hiding this comment.
这里不要用字符串，明明是一个数字，转成number
# Reviewed, transaction id: 29489
# Reviewed, transaction id: 29573
lockiechen
reviewed
Jan 20, 2025
| }, | ||
| maxlength: { | ||
| type: Number, | ||
| default: null |
There was a problem hiding this comment.
判断一下，如果没有maxlength下面的textarea就不要加上这个属性了，没必要弄个default值
# Reviewed, transaction id: 29599
lockiechen
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug：流水线描述内容过长导致编辑后发布报错500 #11404