Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change inverse token chip #1309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

wendellguimaraes-tlf
Copy link
Contributor

@wendellguimaraes-tlf wendellguimaraes-tlf commented Jan 14, 2025

OBVIVO-2618 (Chip): including the use of the inverse token (vars.colors.neutralLow) along with some validations to add it if inverse is true. There is also a small change in the text and icon on the chip to make it readable when using inverse.

https://www.figma.com/design/lvpSfY5tWbxfIXDcyOik78/Chips-Theme-Variant-Inverse?node-id=3518-17481&t=FrpMWuiBsl9w9Xks-0

Copy link

Size stats

master this branch diff
Total JS 12.3 MB 12.3 MB +182 B
JS without icons 2.05 MB 2.05 MB +182 B
Lib overhead 72.8 kB 72.8 kB 0 B
Lib overhead (gzip) 17.1 kB 17.1 kB 0 B

Copy link

github-actions bot commented Jan 14, 2025

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Copy link

github-actions bot commented Jan 14, 2025

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-od82cxhiz-flows-projects-65bb050e.vercel.app

Built with commit 531e929.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Jan 14, 2025

Screenshot tests report

✔️ All passing

Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wendellguimaraes-tlf

The PR is not aligned with the specs definition :(

The file that you linked in PR description is not correct.

https://www.figma.com/design/512a5Ke4EldL0GYffCXGCJ/%F0%9F%94%B8-Chips-Specs?node-id=0-1
This is the official specs for Chips and you can see with a yellow box what parts are pending to be implemented. Please, read the specs and make the changes according to the specs.

If you have any doubts, please address them before starting work to avoid unnecessary effort or wasted time.

Thanks for your effort with this PR anyways 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants