feat(Form): Disable autofocus on error for some fields on iOS #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
pladaria
commented
Jan 2, 2025
Comment on lines
+24
to
+35
| export const isAndroid = (platformOverrides: Theme['platformOverrides']): boolean => { | ||
| if (platformOverrides.platform === 'android') { | ||
| return true; | ||
| } | ||
|
|
||
| return getUserAgent(platformOverrides).toLowerCase().includes('android') && !isEdgeOrIE; | ||
| }; | ||
|
|
||
| export const isIos = (platformOverrides: Theme['platformOverrides']): boolean => { | ||
| if (platformOverrides.platform === 'ios') { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
added to make it easier to force the platform in tests
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 0cfd623. |
atabel
approved these changes
Jan 13, 2025
yceballost
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields that are excluded from autofocus on error in iOS because the focus action opens the picker/selector
Note: scroll to element not affected
A simple unit test that covers these scenarios has been added but you can be manually test this using playroom with a snippet like:
and opening the preview in an iphone