SMARTWIFI-10829 tags update #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeprubio
requested review from
juangardi21,
a team,
yamal-alm and
marinitx
and removed request for
a team
jeprubio
commented
Jan 13, 2025
Comment on lines
-151
to
-158
| TYPE_PROMO -> with(MisticaTheme.colors) { promoLow to promoHigh } | ||
| TYPE_ACTIVE -> with(MisticaTheme.colors) { brandLow to brand } | ||
| TYPE_INACTIVE -> with(MisticaTheme.colors) { neutralLow to neutralMedium } | ||
| TYPE_SUCCESS -> with(MisticaTheme.colors) { successLow to successHigh } | ||
| TYPE_WARNING -> with(MisticaTheme.colors) { warningLow to warningHigh } | ||
| TYPE_ERROR -> with(MisticaTheme.colors) { errorLow to errorHigh } | ||
| TYPE_INVERSE -> with(MisticaTheme.colors) { inverse to brand } | ||
| else -> with(MisticaTheme.colors) { promoLow to promoHigh } |
There was a problem hiding this comment.
Colour changes for compose
jeprubio
commented
Jan 13, 2025
Comment on lines
-91
to
-98
| TYPE_PROMO -> R.attr.colorPromoLow to R.attr.colorPromoHigh | ||
| TYPE_ACTIVE -> R.attr.colorBrandLow to R.attr.colorBrand | ||
| TYPE_INACTIVE -> R.attr.colorNeutralLow to R.attr.colorNeutralMedium | ||
| TYPE_SUCCESS -> R.attr.colorSuccessLow to R.attr.colorSuccessHigh | ||
| TYPE_WARNING -> R.attr.colorWarningLow to R.attr.colorWarningHigh | ||
| TYPE_ERROR -> R.attr.colorErrorLow to R.attr.colorErrorHigh | ||
| TYPE_INVERSE -> R.attr.colorInverse to R.attr.colorBrand | ||
| else -> R.attr.colorPromoLow to R.attr.colorPromoHigh |
There was a problem hiding this comment.
Colour changes for classic views
yceballost
approved these changes
Jan 13, 2025
Sure, I've just added the screenshots in dark mode to the PR description. This github action is failing all the time in uploading the catalog to appcenter https://github.com/Telefonica/mistica-android/actions/runs/12750478199/job/35539118396?pr=404 I'm trying to find out if there is a way for this to be fixed. |
|
📱 New catalog for testing generated: Download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Update tag color tokens and remove inverse.
Discussion about the colors and the inverse removal:
https://teams.microsoft.com/l/message/19:[email protected]/1736771738837?tenantId=9744600e-3e04-492e-baa1-25ec245c6f10&groupId=e265fe99-929f-45d1-8154-699649674a40&parentMessageId=1736771738837&teamName=M%C3%ADstica&channelName=design-appscore&createdTime=1736771738837&ngc=true
🚧 How do we do it?
☑️ Checks
🧪 How can I test this?
If it cannot be tested explain why.