Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANDROID-15325 Compose Input test ids #396

Merged
merged 4 commits into from
Nov 15, 2024
Merged

ANDROID-15325 Compose Input test ids #396

merged 4 commits into from
Nov 15, 2024

Conversation

yamal-alm
Copy link
Contributor

@yamal-alm yamal-alm commented Nov 8, 2024 •
edited
Loading

🥅 What's the goal?

Test IDs for input component (only compose by now)

🚧 How do we do it?

I added the following IDs:

  • TextField
  • PasswordField
  • SearchField
  • PhoneNumberField
  • EmailField
  • DecimalField
  • label
  • helperText
  • endHelperText
  • errorText
  • startIcon
  • endIcon

Following IDs weren't added because associated input fields or features are not implemented yet:

  • CreditCardexpirationField
  • CreditCardNumberField
  • CvvField
  • DateField
  • DateTimeField
  • IbanField
  • IntegerField
  • MonthField
  • PinField
  • placeholder

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies.
  • Accessibility considerations.

🧪 How can I test this?

  • Mistica App QR or download link
  • Reviewed by Mistica design team

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

📱 New catalog for testing generated: Download

@yamal-alm yamal-alm changed the title ANDROID-15325 Compose Input test tags ANDROID-15325 Compose Input test ids Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

📱 New catalog for testing generated: Download

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

📱 New catalog for testing generated: Download

@yamal-alm yamal-alm marked this pull request as ready for review November 8, 2024 12:03
@yamal-alm yamal-alm requested review from a team, DevPabloGarcia, pmartinbTEF and yceballost and removed request for a team November 8, 2024 12:03
pmartinbTEF
pmartinbTEF reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@pmartinbTEF pmartinbTEF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! just one question

DevPabloGarcia
DevPabloGarcia approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@DevPabloGarcia DevPabloGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah !

library/src/main/java/com/telefonica/mistica/compose/input/TextInputTestTags.kt Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

📱 New catalog for testing generated: Download

@yamal-alm yamal-alm merged commit 0fc068f into main Nov 15, 2024
5 checks passed
@yamal-alm yamal-alm deleted the compose-input-test-ids branch November 15, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmartinbTEF pmartinbTEF pmartinbTEF approved these changes

@DevPabloGarcia DevPabloGarcia DevPabloGarcia approved these changes

@yceballost yceballost yceballost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamal-alm @yceballost @DevPabloGarcia @pmartinbTEF