Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANDROID-15220 Update Roborazzi version #389

Merged
merged 3 commits into from
Sep 25, 2024
Merged

ANDROID-15220 Update Roborazzi version #389

merged 3 commits into from
Sep 25, 2024
+2 −2

Conversation

pmartinbTEF
Copy link
Contributor

@pmartinbTEF pmartinbTEF commented Sep 20, 2024 •
edited
Loading

🥅 What's the goal?

Update Roborazzi version and check that screenshot tests are working fine

🚧 How do we do it?

Just updated to the latest version.
Update Screenshot baseline job didn't commit anything as expected

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies.
  • Accessibility considerations.

🧪 How can I test this?

  • Check that compare screenshots job passes
  • Check that update screenshots baseline do not commit anything

@github-actions GitHub Actions
Copy link

📱 New catalog for testing generated: Download

@pmartinbTEF pmartinbTEF changed the title Update Roborazzi version ANDROID-15220 Update Roborazzi version Sep 23, 2024
@pmartinbTEF pmartinbTEF requested review from jeprubio, a team and juangardi21 and removed request for a team September 23, 2024 10:47
@pmartinbTEF pmartinbTEF marked this pull request as ready for review September 23, 2024 10:47
jeprubio
jeprubio reviewed Sep 23, 2024
View reviewed changes
build.gradle Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

📱 New catalog for testing generated: Download

@github-actions GitHub Actions
Copy link

📱 New catalog for testing generated: Download

@pmartinbTEF pmartinbTEF merged commit 7918822 into main Sep 25, 2024
5 checks passed
@pmartinbTEF pmartinbTEF deleted the update_roborazzi_version branch September 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangardi21 juangardi21 juangardi21 approved these changes

@jeprubio jeprubio jeprubio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmartinbTEF @jeprubio @juangardi21