ANDROID-14803 Update all the 24dp lateral margins to 16dp #372
Conversation
|
📱 New catalog for testing generated: Download |
| @@ -69,15 +66,15 @@ | |||
| android:id="@+id/empty_state_screen_primary_button" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:layout_marginStart="24dp" | |||
| android:layout_marginEnd="24dp" | |||
There was a problem hiding this comment.
This is a bit confusing until you find it's meaning, perhaps it could be extracted to a dimension margin_between_buttons or someting like that.
Another perhaps better approach would be to leave them inside the ConstraintLayout and create a chain and set the paddings between elements.
There was a problem hiding this comment.
I prefer the first option because it doesn't imply changing the code. Done!
| android:paddingEnd="24dp" | ||
| android:paddingBottom="24dp" | ||
| android:paddingEnd="16dp" | ||
| android:paddingBottom="16dp" |
There was a problem hiding this comment.
padding bottom should be modified? aren't just lateral margins?
There was a problem hiding this comment.
We should go with 16dp to match when the button is in the bottom on the screen the spacing the button fixed has.
|
📱 New catalog for testing generated: Download |
🥅 What's the goal?
Check that all sides margins of Mistica elements are 16dp (and not 24dp)
🚧 How do we do it?
-Checked Mistica catalog using layout inspector to check sides margins
-Replaced 24dp with 16dp
Only found empty state xml implementation which used 24dp of side margins
I also found that link button of card_actions_view uses a negative margin. I think this should be reviewed in another task
☑️ Checks
🧪 How can I test this?
Before
After
