Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANDROID-14887 update set BottomSheet title as Heading for a11y #369

Merged
merged 1 commit into from
Jul 1, 2024
Merged

ANDROID-14887 update set BottomSheet title as Heading for a11y #369

merged 1 commit into from
Jul 1, 2024

Conversation

jeprubio
Copy link
Contributor

@jeprubio jeprubio commented Jul 1, 2024 •
edited
Loading

🥅 What's the goal?

Set BottomSheet title as Heading for accessibility.

🚧 How do we do it?

  • Set the bottom sheet title as heading.

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies.

🧪 How can I test this?

  • 🖼️ Screenshots/Videos

Before: (video with audio)

BeforeMisticaTitle.mov

After: (video with audio)

AfterMisticaTitle.mov

@jeprubio jeprubio marked this pull request as ready for review July 1, 2024 11:25
@jeprubio jeprubio requested review from a team, dpastor, DevPabloGarcia and paulasuarezb and removed request for a team July 1, 2024 11:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

📱 New catalog for testing generated: Download

dpastor
dpastor approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DevPabloGarcia
DevPabloGarcia approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@DevPabloGarcia DevPabloGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@aweell aweell requested review from aweell and removed request for paulasuarezb July 1, 2024 15:24
@jeprubio jeprubio merged commit 95cbd41 into main Jul 1, 2024
5 checks passed
@jeprubio jeprubio deleted the feature/ANDROID-14887-BottomSheetTitleAsHeading branch July 1, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweell aweell aweell approved these changes

@DevPabloGarcia DevPabloGarcia DevPabloGarcia approved these changes

@dpastor dpastor dpastor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeprubio @dpastor @DevPabloGarcia @aweell