Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback icons for O2 new #367

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Feedback icons for O2 new #367

merged 4 commits into from
Jun 26, 2024

Conversation

yceballost
Copy link
Contributor

@yceballost yceballost commented Jun 21, 2024

https://jira.tid.es/browse/ANDROID-14848

🥅 What's the goal?

Replace custom animation assets for O2-New skin

🧪 How can I test this?

Old New
Foto seleccionada Multimedia (5)
Foto seleccionada (1) Multimedia
Foto seleccionada (2) Multimedia (3)

Copy link

📱 New catalog for testing generated: Download

Copy link

📱 New catalog for testing generated: Download

Copy link

📱 New catalog for testing generated: Download

@yceballost yceballost marked this pull request as ready for review June 24, 2024 10:22
@yceballost yceballost requested a review from dpastor June 24, 2024 10:40
@dpastor
Copy link
Contributor

dpastor commented Jun 24, 2024

Wow! Thanks a lot @yceballost !!! It's correct, but let me just confirm we can merge this now to include this on 24.6 or not.

Thanks again!

@dpastor dpastor requested review from a team and juangardi21 and removed request for a team June 24, 2024 13:36
Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@juangardi21 juangardi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@nimeacuerdo
Copy link
Contributor

@dpastor does this require a 12.x release because of potential issues of having this over the already breaking changes in 13.x?

@dpastor
Copy link
Contributor

dpastor commented Jun 25, 2024

@dpastor does this require a 12.x release because of potential issues of having this over the already breaking changes in 13.x?

I think no, breaking changes in 13.0.0 are very simple (related to snackbars, where a null can be passed), we should be able to publish it as a 13.1.0.

@dpastor dpastor merged commit 52d5c11 into main Jun 26, 2024
5 checks passed
@dpastor dpastor deleted the iceballos-o2New-feeback-icons branch June 26, 2024 10:26
@yceballost yceballost linked an issue Jul 1, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update lottie animations for o2
4 participants