Android 13880 Hide last divider in XML Lists #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeprubio
reviewed
Jan 10, 2024
|
|
||
| val list: MisticaRecyclerView = view.findViewById(R.id.test_list) | ||
| list.adapter = ClickableListAdapter() | ||
| compareScreenshot(Espresso.onView(ViewMatchers.withId(R.id.test_recycler_view))) |
There was a problem hiding this comment.
Shouldn't also be the screenshot (the image) here in the PR?
|
📱 New catalog for testing generated: Download |
jeprubio
reviewed
Jan 10, 2024
Comment on lines
+9
to
+16
| <com.telefonica.mistica.list.MisticaRecyclerView | ||
| android:id="@+id/test_list" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="8dp" | ||
| android:nestedScrollingEnabled="false" | ||
| app:listLayoutType="full_width" | ||
| /> |
There was a problem hiding this comment.
Perhaps this could also be created programmatically and inserted in the dummy layout. But I'm not against this, if we need to test several MisticaRecyclerView elements perhaps it's simpler this way. And it's only a layout in the test directory, should be fine.
There was a problem hiding this comment.
I think this approach is simpler and, as you said, the layout is only added to the test directory :)
jeprubio
approved these changes
Jan 10, 2024
4 tasks
|
📱 New catalog for testing generated: Download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Hide last divider by default in xml lists.
In Compose elements and dividers are added manually so no changes needed
🚧 How do we do it?
Check is last element in DividerItemDecoration
☑️ Checks
🧪 How can I test this?