Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANDROID-14117 Using containers context as others methods #325

Merged
merged 1 commit into from
Dec 28, 2023
Merged

ANDROID-14117 Using containers context as others methods #325

merged 1 commit into from
Dec 28, 2023

Conversation

dagonco
Copy link
Member

@dagonco dagonco commented Dec 28, 2023 •
edited
Loading

🥅 What's the goal?

Fix BottomSheet actions fonts error.

🚧 How do we do it?

  • Using containers context. Same context as other views.

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, update UPGRADING.md to inform users how to proceed. If no updates are necessary, indicate so.
  • Tested with dark mode.
  • Tested with API 23.

🧪 How can I test this?

If it cannot be tested explain why.

  • 🖼️ Screenshots/Videos
  • Mistica App QR or download link
  • Reviewed by Mistica design team

Before: https://github.com/Telefonica/mistica-android/assets/8106237/dd95ad13-4cb2-4c32-a124-5a6c746a5796
After: https://github.com/Telefonica/mistica-android/assets/8106237/e9905095-c07e-4951-bf26-4a3268d8fe96

@dagonco dagonco requested review from jeprubio, jdelga, a team and aweell and removed request for a team December 28, 2023 09:55
@github-actions GitHub Actions
Copy link

📱 New catalog for testing generated: Download

jeprubio
jeprubio approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@jeprubio jeprubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

jdelga
jdelga approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@jdelga jdelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR description, if you use new lines before and after the link video, it should render it inlined.

@dagonco dagonco merged commit 2d26365 into main Dec 28, 2023
5 checks passed
@dagonco dagonco deleted the dagonco/ANDROID-14117-fix-novo-app-font branch December 28, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdelga jdelga jdelga approved these changes

@jeprubio jeprubio jeprubio approved these changes

@aweell aweell Awaiting requested review from aweell aweell was automatically assigned from Telefonica/mistica-design

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagonco @jeprubio @jdelga