-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash #27
Open
SrYthan
wants to merge
30
commits into
Ted80-Minecraft-Mods:master
Choose a base branch
from
GTNewHorizons:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Crash #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1cce77. # Conflicts: # src/main/java/rwg/util/PerlinNoise.java
…un tasks after all
…ng block updates
…asis (#4) * Create NoiseGenerator interface * Make PerlinNoise implement NoiseGenerator interface * Add OpenSimplexNoise, which is the noise used in GTNH 2.2.0.0 * Use NoiseGenerator interface instead of PerlinNoise class for all noise access * Use NoiseGenerator interface instead of PerlinNoise for noise access * Create NoiseSelector class used to instantiate the right noise implementation, and use it everywhere noise generators are created * Introduce config option for noise and use it in NoiseSelector TODO: Convert to enum * Run gradlew spotlessApply * Add /rwg_noise command to set noise function. Currently requires relogging or restarting if server. * Add new /rwg_buginfo command to explain the RWG situation. * Add enum for noise implementation * Use NoiseImplementation enum and load/store it in world data when set by /rwg_noise command. * Add warning message in chat on login if noise type has not been set for this world. * Remove config options as they are now replaced with per-world settings set by commands * Allow the /rwg_buginfo command to be used by anyone * Remove the warning on login as we currently can't detect new worlds * Updated build script * Update buildscript * Translatable command messages * Add a comment explaining commented code with a todo Co-authored-by: Raven Szewczyk <[email protected]>
@SrYthan add a fix here https://github.com/GTNewHorizons/Realistic-World-Gen |
* update bs + deps * spotless * update gradle * remove wildcard import * Add configs for caves, mineshafts, underground lakes, and villages
Co-authored-by: GitHub GTNH Actions <> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Create SupportCC.java * Update Support.java * Update Support.java * Update SupportCC.java * ew ew * ew eww * Revert "ew" This reverts commit bb4231b. * Revert "ew" This reverts commit c53810e. * supcc * add additional statement /** ChromatiCraft is non-supported content. if this ever errors out in some way feel free to remove this.*/ * add config add config * Update SupportTC1.java debug * soptless soptless * Update src/main/java/rwg/config/ConfigRWG.java Co-authored-by: Alexander Anishin <[email protected]> * Update src/main/java/rwg/config/ConfigRWG.java Co-authored-by: Alexander Anishin <[email protected]> * Update src/main/java/rwg/support/Support.java Co-authored-by: Alexander Anishin <[email protected]> * Update src/main/java/rwg/support/SupportTC.java Co-authored-by: Alexander Anishin <[email protected]> * Delete src/main/java/rwg/support/SupportTC1.java * [ci skip] upgraded build system (cherry picked from commit 842fc7e) * update * Update SupportTC.java Class not imported * sa * Update ConfigRWG.java * sa --------- Co-authored-by: Martin Robertz <[email protected]> Co-authored-by: Alexander Anishin <[email protected]> Co-authored-by: Raven Szewczyk <[email protected]>
This reverts commit caf465b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.lang.NullPointerException: Exception generating new chunk
at rwg.world.ChunkGeneratorRealistic.getNewNoise(ChunkGeneratorRealistic.java:207)
at rwg.world.ChunkGeneratorRealistic.generateTerrain(ChunkGeneratorRealistic.java:179)
at rwg.world.ChunkGeneratorRealistic.func_73154_d(ChunkGeneratorRealistic.java:139)
at org.bukkit.craftbukkit.v1_7_R4.generator.NormalChunkGenerator.func_73154_d(NormalChunkGenerator.java:42)
at net.minecraft.world.gen.ChunkProviderServer.originalLoadChunk(ChunkProviderServer.java:260)
at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:218)
at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:186)
at net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:324)
at net.minecraft.world.World.func_72964_e(World.java:779)
at net.minecraft.world.SpawnerAnimals.func_151350_a(SpawnerAnimals.java:38)
at net.minecraft.world.SpawnerAnimals.func_77192_a(SpawnerAnimals.java:137)
at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:257)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:963)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:842)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:692)
at java.lang.Thread.run(Thread.java:750)