Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y – Accessibility version #435

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
f25fa02
Started on weather app, fetching todays weather and the forecast
HeleneWestrin Sep 24, 2024
d2a6506
Added forecast + styling
HeleneWestrin Sep 27, 2024
a92bef3
Restructured code, added day/night functionality, inline input search…
HeleneWestrin Sep 29, 2024
05c1516
Removed images
HeleneWestrin Sep 29, 2024
1460e8a
Favicon update
HeleneWestrin Sep 29, 2024
059335b
Added width and height to image to avoid layout shifts
HeleneWestrin Sep 29, 2024
b5b3b0f
Wait for fonts to load to avoid error in input width
HeleneWestrin Sep 29, 2024
b99c4e0
Small update
HeleneWestrin Sep 29, 2024
8073aea
Fixed messages and images for nighttime
HeleneWestrin Sep 30, 2024
58d140f
Remove is-nighttime if day
HeleneWestrin Sep 30, 2024
59817fb
ReadMe
HeleneWestrin Sep 30, 2024
0b72c49
Small update
HeleneWestrin Sep 30, 2024
0001a47
New message
HeleneWestrin Sep 30, 2024
e992ef3
Nighttime fix
HeleneWestrin Sep 30, 2024
1d681d3
Disable Password Managers
HeleneWestrin Sep 30, 2024
5b2c7a0
Clean-up
HeleneWestrin Sep 30, 2024
d20bb1d
Small update
HeleneWestrin Sep 30, 2024
c04b4f1
Initial changes for better accessibility
HeleneWestrin Oct 1, 2024
ba91337
Clearer messages for screen reader. Empty alt attributes for decorati…
HeleneWestrin Oct 1, 2024
df7a71c
Display the current city's time in sunrise and sunset
HeleneWestrin Oct 1, 2024
bdc8da7
Styling tweak
HeleneWestrin Oct 1, 2024
cc9ff53
Styling tweak
HeleneWestrin Oct 1, 2024
8460906
Updated the No city found message
HeleneWestrin Oct 1, 2024
a13bf98
Correct times for sunrise/sunset + code cleanup
HeleneWestrin Oct 5, 2024
091b286
Separate mainTitle and input for screen readers
HeleneWestrin Oct 5, 2024
3803057
H1 for screen reader fix
HeleneWestrin Oct 6, 2024
9e14206
Added label for screen readers
HeleneWestrin Oct 6, 2024
a842b66
Fix for isDayTime
HeleneWestrin Oct 6, 2024
f75c1d7
Fixed error with local current time + tested removing aria notification
HeleneWestrin Oct 6, 2024
f003252
Refactored getCurrentWeather
HeleneWestrin Oct 6, 2024
9bbc6a4
Re-added the aria notification
HeleneWestrin Oct 6, 2024
836fb27
theme-color added
HeleneWestrin Oct 6, 2024
bfcc6fb
Testing without screen reader H1 solution
HeleneWestrin Oct 6, 2024
40ab086
City name as label
HeleneWestrin Oct 6, 2024
a67d239
Assertive live region
HeleneWestrin Oct 6, 2024
3ddba35
Removed label... screen readers are HARD :P
HeleneWestrin Oct 6, 2024
69c9d11
ReadMe update
HeleneWestrin Oct 6, 2024
0858b91
Meta color update
HeleneWestrin Oct 6, 2024
67c0a6e
Removed unused code
HeleneWestrin Oct 6, 2024
72439f2
Small color update
HeleneWestrin Oct 6, 2024
bf1f4bb
Added aria-labelledby for the forecast title and list
HeleneWestrin Oct 7, 2024
1aabda7
All functions as arrow functions
HeleneWestrin Oct 7, 2024
4532cd1
Comments updated
HeleneWestrin Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Nighttime fix
HeleneWestrin committed Sep 30, 2024

Verified

This commit was signed with the committer’s verified signature.
tariq1890 Tariq
commit e992ef35d546c8a3c51e06b8ddb9908c453bca48
9 changes: 9 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
@@ -193,6 +193,15 @@ h1 {
background-color: #fff;
}

.is-nighttime & {
&:focus {
background-color: #000;
}
&::selection {
background-color: #000;
}
}

&:focus {
outline: none;
background-color: #fff;