The French Bot - Chatbot project - Jenny A #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
What a cute bot idea 🇫🇷 😊 Let's look at some feedback!
JavaScript
- Nice addition with a sound! Crazy idea - would be fun with different sounds if the user answers right or wrong
- The code is divided into logical functions, which is a good practice. For instance, separating the playSendSound and playReceiveSound functions helps keep the code modular.
- If the user clicks the send button multiple times quickly, it might cause unintended behavior (e.g., repeated messages). To prevent this, consider disabling the input field and button temporarily during processing.
Clean Code
- Variables and functions have clear and descriptive names, such as handleNameInput, createFrenchButtons, and playSendSound. This makes the code readable and maintainable. Consider changing e.g. goodByeMessage to follow the same convention
Nice idea and well executed ⭐
| Send | ||
| </button> | ||
| </form> | ||
| <div id="button-container" style="display: none;"></div> |
There was a problem hiding this comment.
Keep styling out of the HTML file 👀
| buttonContainer.style.display = 'flex'; // Show buttons | ||
|
|
||
| // Add event listeners to buttons | ||
| buttonContainer.querySelectorAll('button').forEach(button => { |
There was a problem hiding this comment.
Nice usage of forEach 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://thefrenchbot.netlify.app/