[feat] 에셋 추가 및 수정사항 반영 - 지현 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAJIEUN02
approved these changes
Jan 9, 2024
| CategoryType.STUDY -> if (isSelected) MapFragment.OVERLAY_IMAGE_STUDY_BIG else MapFragment.OVERLAY_IMAGE_STUDY_SMALL | ||
| CategoryType.MULTI -> if (isSelected) MapFragment.OVERLAY_IMAGE_MULTI_BIG else MapFragment.OVERLAY_IMAGE_MULTI_SMALL | ||
| CategoryType.OTHERS -> if (isSelected) MapFragment.OVERLAY_IMAGE_OTHER_BIG else MapFragment.OVERLAY_IMAGE_OTHER_SMALL | ||
| CategoryType.PLAY -> if (isSelected) MapFragment.OVERLAY_IMAGE_PIN_PLAY_ACTIVE else MapFragment.OVERLAY_IMAGE_PIN_PLAY_DEFAULT |
There was a problem hiding this comment.
presentation layer에도 매퍼가 있는지는 몰랐군요.. 먼가 서버의 데이터 -> 필요한 것만 저장하는 엔티티 이런 매퍼처럼 딱 역할이 정해져 있다기보다는 그게 뭐든 유아이에서만 쓰이는 애들 매핑해주는 고런 느낌인가여?
There was a problem hiding this comment.
지도에서 쓰려고 만들었어요
매퍼의 데이터 클래스를 다른 형태로 매핑할 때 쓰려구염
| val OVERLAY_IMAGE_STUDY_BIG = OverlayImage.fromResource(R.drawable.ic_map_marker_study_big) | ||
| val OVERLAY_IMAGE_MULTI_BIG = OverlayImage.fromResource(R.drawable.ic_map_marker_multi_big) | ||
| val OVERLAY_IMAGE_OTHER_BIG = OverlayImage.fromResource(R.drawable.ic_map_marker_other_big) | ||
| val OVERLAY_IMAGE_PIN_PLAY_DEFAULT = |
There was a problem hiding this comment.
언니는 상수화의 신이다
진짜 근데 꼼꼼하당 나같으면 변수명 걍 넘겼을텐데..
| } else { | ||
| with(tvCardTopInfoParticipantDetail) { |
There was a problem hiding this comment.
미폈다 spannable을 이런 식으로 수정한 건가요?? 훨씬 보기 조으당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240110_043228.mp4
Uncompleted Tasks 😅
To Reviewers 📢
ㅋㅋ