Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[init] colors 기초 세팅 #8

Merged
merged 2 commits into from
Jan 1, 2024
Merged

[init] colors 기초 세팅 #8

merged 2 commits into from
Jan 1, 2024

Conversation

HAJIEUN02
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • 스타일 가이드 기반으로 colors.xml 기초 세팅 완료했습니다!

Screenshot 📸

생략

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

  • N/A

@HAJIEUN02 HAJIEUN02 requested a review from a team as a code owner January 1, 2024 11:41
@HAJIEUN02 HAJIEUN02 changed the title [init] #7 colors 기초 세팅 [init] colors 기초 세팅 Jan 1, 2024
@HAJIEUN02 HAJIEUN02 self-assigned this Jan 1, 2024
@HAJIEUN02 HAJIEUN02 added this to the 프로젝트 기초 세팅 milestone Jan 1, 2024
jihyunniiii
jihyunniiii approved these changes Jan 1, 2024
View reviewed changes
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했서염 ! 네이밍 조금만 수정 부탁해용
그리고 이슈랑 pr에서 프로젝트 선택할 때 status 도 선택해주세용!

app/src/main/res/values/colors.xml Show resolved Hide resolved
app/src/main/res/values/colors.xml Outdated Show resolved Hide resolved
app/src/main/res/values/colors.xml

<!--backdrop-->
<color name="backdrop">#B3080909</color>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알려주지 않아도 야무진 우리 막냉이 >.<

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우헤헤😎🧡🧡

jihyunniiii
jihyunniiii approved these changes Jan 1, 2024
View reviewed changes
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지합시다 ~ 고생했어요

@HAJIEUN02 HAJIEUN02 merged commit 7fadd7b into develop Jan 1, 2024
1 check passed
@HAJIEUN02 HAJIEUN02 deleted the init-color-setting branch January 1, 2024 12:06
@jihyunniiii jihyunniiii restored the init-color-setting branch January 1, 2024 13:58
@jihyunniiii jihyunniiii deleted the init-color-setting branch January 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihyunniiii jihyunniiii jihyunniiii approved these changes

Assignees

@HAJIEUN02 HAJIEUN02

Labels
⚡️ init ⚡️ 🐹 지은 🐹
Projects
PINGLE-ANDROID
Status: Done
Milestone
프로젝트 기초 세팅
Development

Successfully merging this pull request may close these issues.

[init] color 기초세팅
2 participants
@HAJIEUN02 @jihyunniiii