[feat] 번개 생성 개최 뷰 - 시간 / 날짜 뷰 구현 #43

Dan2dani · 2024-01-06T08:30:45Z

Related issue 🛠

closed [feat] 핑글 개최 프로세스 - 시간/날짜 뷰 구현 #38

Work Description ✏️

번개 생성 개최 뷰 - 시간 / 날짜 뷰 구현

Screenshot 📸

HD20240106_172127.1.mp4

Uncompleted Tasks 😅

시간 텍스트 포맷에 맞춰 뷰에 띄우기
스낵바 띄우기
버튼 활성화 적용

To Reviewers 📢

jihyunniiii

잘했숨니당 ㅋ.ㅋ

app/src/main/java/org/sopt/pingle/presentation/ui/main/plan/PlanTimeDialogFragment.kt

jihyunniiii · 2024-01-06T08:47:28Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/plan/PlanTimeDialogFragment.kt

+    companion object {
+        const val HOUR_MIN = 1
+        const val HOUR_MAX = 12
+        const val MINUTE_MIN = 0
+        const val MINUTE_MAX = 59
+    }


잘했어욤 ~

jihyunniiii · 2024-01-06T08:47:41Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/plan/PlanViewModel.kt

+        _planDate.value = planDate
+    }
+
+    fun setSelectedTimeType(timeType: String) {


jihyunniiii · 2024-01-06T08:48:13Z

app/src/main/res/layout/dialog_time_picker.xml

+
+    <androidx.constraintlayout.widget.ConstraintLayout
+        android:layout_width="match_parent"
+


에바핑 ㅋㅋ

jihyunniiii · 2024-01-06T08:48:57Z

app/src/main/res/layout/dialog_time_picker.xml

+            android:text="Done"
+            android:textAlignment="textEnd"
+            android:textColor="@color/pingle_green"
+            android:textSize="18dp"
+            app:layout_constraintEnd_toEndOf="parent"


폰트 다운받아서 해주세영

HAJIEUN02 · 2024-01-06T09:09:02Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/plan/PlanViewModel.kt


    fun setCurrentPage(position: Int) {
        _currentPage.value = position
    }

+    fun setPlanDate(planDate: String) {


우하하 이런 식으루 뷰모델에 저장하는 것이로군 쇽샥!!!!!!!!!!!!!!!!!!!!!!!

# Conflicts: # app/src/main/res/values/strings.xml

jihyunniiii · 2024-01-06T13:28:55Z

담부터 린트 체크 안 돌아가고 머지하면 혼난당 ~

jihyunniiii

그만 잘해 이다은

jihyunniiii · 2024-01-07T21:01:19Z

app/src/main/java/org/sopt/pingle/presentation/type/MeridiemType.kt

+enum class MeridiemType(
+    @StringRes val meridiemStringRes: Int
+) {
+    AM(R.string.plan_time_am), PM(R.string.plan_time_pm)
+}


타입 관리 미쳤네염

jihyunniiii · 2024-01-07T21:16:46Z

app/src/main/res/layout/dialog_date_picker.xml

+            android:background="@color/g_11"
+            android:paddingVertical="7dp"
+            android:paddingEnd="15dp"
+            android:text="Done"


추출 부탁합니둥

jihyunniiii · 2024-01-07T21:21:40Z

app/src/main/res/layout/dialog_date_picker.xml

+        <NumberPicker
+            android:id="@+id/np_date_picker_year"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginVertical="20dp"
+            android:layout_marginStart="44dp"
+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@+id/tv_date_picker_done" />
+
+        <NumberPicker
+            android:id="@+id/np_date_picker_month"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="@+id/np_date_picker_year"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="@+id/np_date_picker_year" />
+
+        <NumberPicker
+            android:id="@+id/np_date_picker_day"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginEnd="44dp"
+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="@+id/np_date_picker_month"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintTop_toTopOf="@+id/np_date_picker_month" />


이거 체인 거는 게 나을 것 같습니다요

jihyunniiii · 2024-01-07T21:22:21Z

app/src/main/res/layout/dialog_time_picker.xml

+            android:background="@color/g_11"
+            android:paddingVertical="7dp"
+            android:paddingEnd="15dp"
+            android:text="Done"


추출 해주세용

jihyunniiii · 2024-01-07T21:22:58Z

app/src/main/res/layout/dialog_time_picker.xml

+        <NumberPicker
+            android:id="@+id/np_time_picker_meridiem"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginVertical="20dp"
+            android:layout_marginStart="44dp"
+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@+id/tv_time_picker_done" />
+
+        <NumberPicker
+            android:id="@+id/np_time_picker_hour"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="@+id/np_time_picker_meridiem"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="@+id/np_time_picker_meridiem" />
+
+        <NumberPicker
+            android:id="@+id/np_time_picker_minute"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginEnd="44dp"
+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="@+id/np_time_picker_hour"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintTop_toTopOf="@+id/np_time_picker_hour" />


jihyunniiii · 2024-01-07T21:28:57Z

app/src/main/res/layout/view_text_with_title.xml

+        android:paddingVertical="@dimen/spacing16">
+
+        <TextView
+            android:id="@+id/tv_title"


네이밍 tv_text_with_title_title 이런 식으로 부탁티비요 ~
유형_어느 뷰인지_뭔지

HAJIEUN02

💥💛💪💥

HAJIEUN02 · 2024-01-12T18:53:27Z

app/src/main/java/org/sopt/pingle/util/component/PingleEditText.kt

@@ -10,11 +10,13 @@ import org.sopt.pingle.R
 import org.sopt.pingle.databinding.EditTextPingleBinding

 @SuppressLint("CustomViewStyleable")
-class PingleEditText(
+class PingleEditText @JvmOverloads constructor(


오와 생성자 오버로딩을 자동으로 생성해주는 어노테이션이라니 나중에 이런 식으로 커스텀뷰 만들 때 참고할게요~!

HAJIEUN02 · 2024-01-12T18:53:48Z

app/src/main/res/layout/dialog_date_picker.xml

+            android:theme="@style/AppTheme.NumberPicker"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@+id/tv_date_picker_done" />


여기 제약에 @id 사용해주세욥

HAJIEUN02 · 2024-01-12T18:53:55Z

app/src/main/res/layout/dialog_date_picker.xml

+            app:layout_constraintBottom_toBottomOf="@+id/np_date_picker_year"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="@+id/np_date_picker_year" />


Dan2dani added 9 commits January 6, 2024 17:19

[feat] #38 PingleEditText 속성에 text 추가

9f11f8a

[feat] #38 date, time picker 뷰 디자인

410a634

[feat] #38 넘버 피커 스타일 생성

d3a6dd9

[feat] #38 핑글 개최 프로세스 - 시간/날짜 뷰 스트링 추출

a090d31

[feat] #38 핑글 개최 프로세스 - 시간/날짜에 필요한 타이틀을 가진 텍스트뷰 재활용을 위한 디자인

244e160

[feat] #38 핑글 개최 프로세스 - 시간/날짜 뷰 디자인

4120425

[feat] #38 핑글 개최 프로세스 - 시간/날짜 넘버피커 프래그먼트 구현

b6311cf

[feat] #38 핑글 개최 프로세스 - 시간/날짜, 핑글 날짜, 시작, 종료 시간 선택을 확인하는 flow 생성

038a059

[feat] #38 핑글 개최 프로세스 - 시간/날짜 프래그먼트 구현

7e356d5

Dan2dani added ✨ feat ✨ 🐰 다은 🐰 labels Jan 6, 2024

Dan2dani added this to the 1차 스프린트 뷰 작업 milestone Jan 6, 2024

Dan2dani self-assigned this Jan 6, 2024

Dan2dani requested a review from a team as a code owner January 6, 2024 08:30

jihyunniiii approved these changes Jan 6, 2024

View reviewed changes

Dan2dani added 2 commits January 6, 2024 18:05

[feat] #38 오전 오후 type으로 관리하는걸로 수정

18876e3

[feat] #38 xml 빈칸 제거

b0669e9

HAJIEUN02 reviewed Jan 6, 2024

View reviewed changes

Dan2dani added 2 commits January 6, 2024 18:16

[mod] #38 MeridiemType 타입 수정

36ffbef

Merge branch 'develop' into feat-plan-date-time-view

bb5632c

# Conflicts: # app/src/main/res/values/strings.xml

Dan2dani merged commit 5b73f79 into develop Jan 6, 2024
1 check failed

jihyunniiii deleted the feat-plan-date-time-view branch January 7, 2024 20:10

jihyunniiii reviewed Jan 7, 2024

View reviewed changes

HAJIEUN02 reviewed Jan 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] 번개 생성 개최 뷰 - 시간 / 날짜 뷰 구현 #43

[feat] 번개 생성 개최 뷰 - 시간 / 날짜 뷰 구현 #43

Dan2dani commented Jan 6, 2024 •

edited

Loading

jihyunniiii left a comment

jihyunniiii Jan 6, 2024

jihyunniiii Jan 6, 2024

jihyunniiii Jan 6, 2024

jihyunniiii Jan 6, 2024

HAJIEUN02 Jan 6, 2024

jihyunniiii commented Jan 6, 2024

jihyunniiii left a comment

jihyunniiii Jan 7, 2024

jihyunniiii Jan 7, 2024

jihyunniiii Jan 7, 2024

jihyunniiii Jan 7, 2024

jihyunniiii Jan 7, 2024

jihyunniiii Jan 7, 2024

HAJIEUN02 left a comment

HAJIEUN02 Jan 12, 2024

HAJIEUN02 Jan 12, 2024

HAJIEUN02 Jan 12, 2024


		<androidx.constraintlayout.widget.ConstraintLayout
		android:layout_width="match_parent"

[feat] 번개 생성 개최 뷰 - 시간 / 날짜 뷰 구현 #43

[feat] 번개 생성 개최 뷰 - 시간 / 날짜 뷰 구현 #43

Conversation

Dan2dani commented Jan 6, 2024 • edited Loading

Related issue 🛠

Work Description ✏️

Screenshot 📸

Uncompleted Tasks 😅

To Reviewers 📢

jihyunniiii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jihyunniiii commented Jan 6, 2024

jihyunniiii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HAJIEUN02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dan2dani commented Jan 6, 2024 •

edited

Loading