Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 메인 지도 뷰 참여모달 구현 #30

Merged
merged 9 commits into from
Jan 5, 2024
Merged

[feat] 메인 지도 뷰 참여모달 구현 #30

merged 9 commits into from
Jan 5, 2024

Conversation

jihyunniiii
Copy link
Collaborator

@jihyunniiii jihyunniiii commented Jan 5, 2024 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • 메인 지도 뷰의 참여모달을 구현했습니다.

Screenshot 📸

Screen_recording_20240105_102518.mp4

Uncompleted Tasks 😅

  • 디쟌핑에게 문의한 내용 반영 X (좌우 정렬 되어있지 않은 부분, 모달 크기 고정 -> 모달 크기 동적으로 늘어나도록 구현)
    => 답변 오면 반영할게요!

To Reviewers 📢

  • stringOf, colorOf, drawableOf 확장함수 ViewExt에도 추가해두었으니 자유롭게 사용하시면 됩니당 ~
  • BindingDialogFragment에도 배경색 지정해두었으니 확인해주세용

@jihyunniiii jihyunniiii self-assigned this Jan 5, 2024
@jihyunniiii jihyunniiii requested a review from a team as a code owner January 5, 2024 01:31
Doreminwoo
Doreminwoo approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@Doreminwoo Doreminwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

app/src/main/res/values/dimens.xml
@@ -33,4 +33,7 @@
<dimen name="button_l_height">56dp</dimen>
<dimen name="button_m_height">42dp</dimen>
<dimen name="button_s_height">42dp</dimen>

<dimen name="dialog_horizontal_margin">24dp</dimen>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 나누는게 재사용성이 더 좋을 것 같아요!!!
굳굳굳

@HAJIEUN02 HAJIEUN02 self-requested a review January 5, 2024 10:18
HAJIEUN02
HAJIEUN02 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많아쑴다🐾 므찌다 울언니.... 언니 이제 잠 좀 자

app/src/main/res/layout/dialog_map_modal.xml Outdated
android:textColor="@color/g_10"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/gl_end"
app:layout_constraintStart_toStartOf="@+id/gl_start"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 찾았따 @+id
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ완벽한 코드에서 오점 열심히 찾기

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉,,, 당장 수정하겠습니다

app/src/main/java/org/sopt/pingle/presentation/ui/main/home/map/MapModalDialogFragment.kt Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얼른 내 뷰를 뚝딱뚝딱 끝내고 모달 재사용뷰 만들었어야 헀는데.....

@jihyunniiii
[chore] #29 @+id -> @id
0f4c75d
@jihyunniiii
Merge branch 'develop' into feat-main-map-modal
06194cb 
# Conflicts:
#	app/src/main/res/values/dimens.xml
#	app/src/main/res/values/strings.xml
@jihyunniiii jihyunniiii merged commit 53c883d into develop Jan 5, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the feat-main-map-modal branch January 5, 2024 17:13
@HAJIEUN02 HAJIEUN02 linked an issue Jan 6, 2024 that may be closed by this pull request
[feat] 핑글 개최 프로세스 - 내용요약/확인 뷰 구현 #42
Closed
3 tasks
@HAJIEUN02 HAJIEUN02 removed a link to an issue Jan 6, 2024
[feat] 핑글 개최 프로세스 - 내용요약/확인 뷰 구현 #42
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doreminwoo Doreminwoo Doreminwoo approved these changes

@HAJIEUN02 HAJIEUN02 HAJIEUN02 approved these changes

Assignees

@jihyunniiii jihyunniiii

Labels
✨ feat ✨ 🐸 지현 🐸
Projects
PINGLE-ANDROID
Status: Done
Milestone
1차 스프린트 뷰 작업
Development

Successfully merging this pull request may close these issues.

[feat] 메인 지도 뷰 참여모달 구현
3 participants
@jihyunniiii @HAJIEUN02 @Doreminwoo