[hotfix] 신규단체개설뷰 이슈 해결 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doreminwoo
approved these changes
Mar 13, 2024
| @@ -48,13 +48,12 @@ class NewGroupKeywordFragment : | |||
| } | |||
|
|
|||
| private fun collectData() { | |||
| newGroupViewModel.newGroupKeywordsState.flowWithLifecycle(lifecycle).onEach { uiState -> | |||
| newGroupViewModel.newGroupKeywordsState.flowWithLifecycle(viewLifecycleOwner.lifecycle).onEach { uiState -> | |||
There was a problem hiding this comment.
내가 나중에 리팩할려고 아껴둔건데 ㅠㅠㅠㅠㅠㅠㅠㅠㅠ
There was a problem hiding this comment.
ㅋㅋ 이런 건 빨리 리팩하라핑
| val newGroupKeywordName = MutableStateFlow<String>("") | ||
| val newGroupKeywordValue = MutableStateFlow<String>("") | ||
|
|
||
| val isNewGroupBtnEnabled: StateFlow<Boolean> = listOf( | ||
| currentPage, | ||
| newGroupName, | ||
| newGroupEmail, | ||
| isNewGroupBtnCheckName, | ||
| isGroupNameDuplicatedCheck, |
There was a problem hiding this comment.
아 ㅋㅋ 오빠가 만들어놓은 거랑 다른 목적으로 사용하려고 네이밍 수정했슴다 ㅋㅋ ㅜㅜ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240313_152655.mp4
Uncompleted Tasks 😅
To Reviewers 📢
ㅠㅠ핑