Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 커스텀 에딧 텍스트 뷰 구현 #20

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

Dan2dani
Copy link
Collaborator

@Dan2dani Dan2dani commented Jan 2, 2024

Related issue 🛠

Work Description ✏️

  • 커스텀 에딧 텍스트 뷰 구현

Screenshot 📸

@Dan2dani Dan2dani requested a review from a team as a code owner January 2, 2024 14:05
@Dan2dani Dan2dani self-assigned this Jan 2, 2024
@Dan2dani Dan2dani added this to the 1차 스프린트 뷰 작업 milestone Jan 2, 2024
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선생님 오늘도 배워갑니둥 ㅜ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네이밍 변경 부탁드립니당
shape_pingle_green_solid_width_1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 약간 애매쓰한겡 커서에만 쓰여서..훔냐 일부러 좀 명시적이게 해써염

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그럼 shape로 시작되게라도 통일 시키는 게 어떠신지용 ㅜ 근데 네이밍이 고민되긴 하네염 ㅋ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조아염

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커스텀뷰 클래스의 이름을 PingleEditText로 지었으면 xml에서는 이거 반대로 가는게 컨벤션인가염?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보통 그렇지 않나염?! 클래스랑 xml 이랑

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 저 사실 그냥 누군가으 ㅣ컨벤션을 따라했어요

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그럼 저도 따라갈게요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ우린 따라가기..대마왕

Copy link
Member

@Doreminwoo Doreminwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 많이 배워갑니다 ㅠㅠㅠㅜㅜㅜ

import org.sopt.pingle.databinding.ActivityEditTextCustomTestBinding
import org.sopt.pingle.util.base.BindingActivity

class DummyCustomDEditTextActivity : BindingActivity<ActivityEditTextCustomTestBinding>(R.layout.activity_edit_text_custom_test) {
Copy link
Member

@Doreminwoo Doreminwoo Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클래스 이름에 D 오타인가여!?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

거슬려염 ㅋ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 미친 ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 너무 급했네 이거 근데 차피 지울거라 걍 냅둬도 될까염 ㅋㅅㅋ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 그럽시당

import org.sopt.pingle.R
import org.sopt.pingle.databinding.EditTextPingleBinding

@SuppressLint("CustomViewStyleable")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우옹... 처음보는거네요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅈ..저도 처음보는데 저거 안달면 자꾸 밑줄생겨서

android:paddingVertical="@dimen/spacing16">

<TextView
android:id="@+id/tv_title"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
android:id="@+id/tv_title"
android:id="@+id/tv_edit_text_pingle_title"

유형_어떤 뷰인지_역할 컨벤션 지켜주십쇼 ㅜ 아래두여

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고치겠습니당

@HAJIEUN02 HAJIEUN02 self-requested a review January 2, 2024 16:22
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴미당! 빨리 쓰고 싶어요 얼른 머지해주세요!!!!! 두근두근

private fun initView(typedArray: TypedArray) {
binding = EditTextPingleBinding.inflate(LayoutInflater.from(context), this, true)
typedArray.apply {
val title = getString(R.styleable.pingleEditText_title)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오왕 styleable은 처음 보네요

android:id="@+id/tv_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:textAppearance="@style/TextAppearance.Pingle.Cap.Semi.12"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint 사이즈는 코드 상에서 조절하면 되는 거 맞나용? hint랑 text 사이즈가 다른데 힌트 사이즈는 따로 설정할 수 없구 textSize를 따라간다고 해서요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

힌트랑 텍스트 크기 다른가여? ㅋㅋㅋㅋ ㅜ 확인하겠습니다

android:textColor="@color/g_03"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
tools:text="제목" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제목이 필요 없는 뷰인 경우에도 사용할 수 있나요?? 제가 개최 프로세스 4번 뷰에서 에딧텍스트 커스텀한 검색창을 써야 하는데 제목 없고 이미지를 하나 추가해야 되거든욤,, 아예 이 커스텀 에딧텍스트뷰를 못 쓰는 걸까욤

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검색창은 검색 버튼도 따로 있어서 따로 쓰는게 나을거 같아요!

android:layout_height="wrap_content"
android:layout_marginTop="4dp"
android:background="@null"
android:imeOptions="actionDone"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imeOptions 이 태그는 뭔가요?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 키보드에 저 엔터 버튼 같은거 뭐로 뜨게 할지 조정하는거에요! image

@Dan2dani Dan2dani merged commit abe3c2c into develop Jan 3, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the feat-custom-edittext branch January 3, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] edittext 커스텀뷰 제작(실험용)
4 participants