[feat] 검색 뷰 구현 #188
Merged
[feat] 검색 뷰 구현 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAJIEUN02
approved these changes
Feb 17, 2024
app/src/main/AndroidManifest.xml
Outdated
There was a problem hiding this comment.
순서 정렬 + 새 액티비티 생성 때문에 수정하였습니당
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="145dp" | ||
| android:src="@drawable/img_search_pingle_graphic" | ||
| app:layout_constraintEnd_toStartOf="@+id/gl_end" |
There was a problem hiding this comment.
아놔 왜 이리 예리하신지요
| <string name="my_pingle_topbar">마이핑글</string> | ||
| <string name="my_pingle_soon">홈으로 이동해\n내 주변 핑글을 찾아보세요!</string> | ||
| <string name="my_pingle_done">아직 참여한 핑글이 없어요\n첫 핑글과 함께 네트워킹을 시작해보세요!</string> | ||
| <string name="my_pingle_tab_soon">\t\t\t\t\t\t\t예정된\t\t\t\t\t\t\t\t</string> |
There was a problem hiding this comment.
아 이거 ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 커스텀 안 하려고 ㅋㅋㅋㅋㅋㅋㅋㅋ 민우핑이 나중에 리팩 해줄 거에요,, (아마도)
@Doreminwoo
| @@ -14,6 +14,7 @@ import org.sopt.pingle.presentation.ui.common.WebViewActivity.Companion.WEB_VIEW | |||
| fun Context.hideKeyboard(view: View) { | |||
| val inputMethodManager = getSystemService(Activity.INPUT_METHOD_SERVICE) as InputMethodManager | |||
| inputMethodManager.hideSoftInputFromWindow(view.windowToken, 0) | |||
| view.clearFocus() | |||
There was a problem hiding this comment.
헐 이런게 있따니 나 안그래도 오늘 ㅜ 타프젝 작업하면서 포커스가 넘 거슬렸는데ㅠㅠ 바로 적용해야딩 우헤헤
jihyunniiii
commented
Feb 20, 2024
Comment on lines
39
to
59
| <ImageView | ||
| android:id="@+id/iv_search_search_pingle" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="145dp" | ||
| android:src="@drawable/img_search_pingle_graphic" | ||
| app:layout_constraintEnd_toStartOf="@id/gl_end" | ||
| app:layout_constraintStart_toStartOf="@id/gl_start" | ||
| app:layout_constraintTop_toBottomOf="@id/pingle_search_search" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/tv_search_search_description" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="20dp" | ||
| android:text="@string/search_description" | ||
| android:textAppearance="@style/TextAppearance.Pingle.Body.Med.16" | ||
| android:textColor="@color/g_02" | ||
| app:layout_constraintEnd_toStartOf="@id/gl_end" | ||
| app:layout_constraintStart_toStartOf="@id/gl_start" | ||
| app:layout_constraintTop_toBottomOf="@id/iv_search_search_pingle" /> |
There was a problem hiding this comment.
중앙 정렬로 수정 (키보드 올라왔을 때 안 가리도록 수정)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240225_004507.mp4
Uncompleted Tasks 😅
To Reviewers 📢